Merge pull request #18 from paulfantom/sync_upstream

Sync with upstream

.circleci/config.yml

@@ -73,7 +73,7 @@ jobs:
       - run:
           name: Build Docker image
           command: |
-            apk add -U make
+            apk add -U make bash
             make docker GOOS=linux GOARCH=amd64 DOCKER_IMAGE_TAG=${CIRCLE_SHA1}
 
       - run:

Makefile

@@ -12,13 +12,14 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+SHELL := /bin/bash -euo pipefail
+
 # Use the native vendor/ dependency system
 export GO111MODULE := on
 export CGO_ENABLED := 0
 
 GOOS ?= $(shell go env GOOS)
 GOARCH ?= $(shell go env GOARCH)
-BUILD_DIR ?= ./out
 ORG := github.com/jimmidyson
 REPOPATH ?= $(ORG)/configmap-reload
 DOCKER_IMAGE_NAME ?= jimmidyson/configmap-reload
@@ -28,35 +29,33 @@ LDFLAGS := -s -w -extldflags '-static'
 
 SRCFILES := $(shell find . ! -path './out/*' ! -path './.git/*' -type f)
 
-out/configmap-reload: out/configmap-reload-$(GOOS)-$(GOARCH)
-	cp $(BUILD_DIR)/configmap-reload-$(GOOS)-$(GOARCH) $(BUILD_DIR)/configmap-reload
-
-out/configmap-reload-linux-ppc64le: $(SRCFILES)
-	GOARCH=ppc64le GOOS=linux go build --installsuffix cgo -ldflags="$(LDFLAGS)" -a -o $(BUILD_DIR)/configmap-reload-linux-ppc64le configmap-reload.go
+ALL_BINARIES ?= $(addprefix out/configmap-reload-, \
+									$(addprefix linux-,amd64 ppc64le s390x arm64) \
+									darwin-amd64 \
+									windows-amd64.exe)
 
-out/configmap-reload-darwin-amd64: $(SRCFILES)
-	GOARCH=amd64 GOOS=darwin go build --installsuffix cgo -ldflags="$(LDFLAGS)" -a -o $(BUILD_DIR)/configmap-reload-darwin-amd64 configmap-reload.go
-
-out/configmap-reload-linux-amd64: $(SRCFILES)
-	GOARCH=amd64 GOOS=linux go build --installsuffix cgo -ldflags="$(LDFLAGS)" -a -o $(BUILD_DIR)/configmap-reload-linux-amd64 configmap-reload.go
+out/configmap-reload: out/configmap-reload-$(GOOS)-$(GOARCH)
+	cp out/configmap-reload-$(GOOS)-$(GOARCH) out/configmap-reload
 
-out/configmap-reload-windows-amd64.exe: $(SRCFILES)
-	GOARCH=amd64 GOOS=windows go build --installsuffix cgo -ldflags="$(LDFLAGS)" -a -o $(BUILD_DIR)/configmap-reload-windows-amd64.exe configmap-reload.go
+out/configmap-reload-%: $(SRCFILES)
+	GOARCH=$(word 2,$(subst -, ,$(*:.exe=))) GOOS=$(word 1,$(subst -, ,$(*:.exe=))) \
+		go build --installsuffix cgo -ldflags="$(LDFLAGS)" -a \
+		-o $@ configmap-reload.go
 
 .PHONY: cross
-cross: out/configmap-reload-linux-s390x out/configmap-reload-linux-ppc64le out/configmap-reload-linux-arm64 out/configmap-reload-linux-amd64 out/configmap-reload-darwin-amd64 out/configmap-reload-windows-amd64.exe
+cross: $(ALL_BINARIES)
 
 .PHONY: checksum
 checksum:
-	for f in out/configmap-reload-linux-amd64 out/configmap-reload-darwin-amd64 out/configmap-reload-windows-amd64.exe ; do \
+	for f in $(ALL_BINARIES) ; do \
 		if [ -f "$${f}" ]; then \
 			openssl sha256 "$${f}" | awk '{print $$2}' > "$${f}.sha256" ; \
 		fi ; \
 	done
 
 .PHONY: clean
 clean:
-	rm -rf $(BUILD_DIR)
+	rm -rf out
 
 .PHONY: docker
 docker: out/configmap-reload Dockerfile