Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move console operator into a separate namespace #116

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Move console operator into a separate namespace #116

merged 1 commit into from
Jan 28, 2019

Conversation

spadgett
Copy link
Member

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2019
@benjaminapetersen
Copy link
Contributor

so far so good....

@benjaminapetersen
Copy link
Contributor

i think both flakes.

/retest

@spadgett
Copy link
Member Author

Operator needs some additional permissions in its own namespace. Working on that now

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 25, 2019
@spadgett spadgett force-pushed the update-operator-ns branch 3 times, most recently from 7bc462e to 75d598b Compare January 26, 2019 00:42
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2019
@spadgett
Copy link
Member Author

/retest

1 similar comment
@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

Operator and console look healthy from the logs. Looks like a flake.

/retest

@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

Tests are green

@spadgett spadgett changed the title [WIP] Move console operator into a separate namespace Move console operator into a separate namespace Jan 26, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2019
@benjaminapetersen
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2019
@benjaminapetersen
Copy link
Contributor

Awesome.

benjaminapetersen
benjaminapetersen reviewed Jan 28, 2019
View reviewed changes
manifests/04-config.yaml
@@ -1,14 +1,14 @@
apiVersion: v1
kind: ConfigMap
metadata:
namespace: openshift-console
namespace: openshift-console-operator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changing the same values across the manifests. I want something like helm template to be able to use consts across these, but hopefully wont have tons of changes in the future.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [benjaminapetersen,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 37991a6 into openshift:master Jan 28, 2019
@spadgett spadgett deleted the update-operator-ns branch January 28, 2019 16:54
@spadgett spadgett mentioned this pull request Jan 28, 2019
Closed
@benjaminapetersen
Copy link
Contributor

🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@enj enj Awaiting requested review from enj

Assignees

@benjaminapetersen benjaminapetersen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spadgett @benjaminapetersen @openshift-ci-robot @openshift-merge-robot