New version bump #119
New version bump #119
Conversation
openshift-ci-robot
added
the
size/XXL
| @@ -114,10 +114,16 @@ func sync_v400(co *consoleOperator, consoleConfig *v1alpha1.Console) (*v1alpha1. | |||
| func SyncDeployment(co *consoleOperator, recorder events.Recorder, consoleConfig *v1alpha1.Console, cm *corev1.ConfigMap, serviceCAConfigMap *corev1.ConfigMap, sec *corev1.Secret) (*appsv1.Deployment, bool, error) { | |||
| logrus.Printf("validating console deployment...") | |||
| defaultDeployment := deploymentsub.DefaultDeployment(consoleConfig, cm, serviceCAConfigMap, sec) | |||
| versionAvailability := &operatorv1alpha1.VersionAvailability{ | |||
| Version: consoleConfig.Spec.Version, | |||
| versionAvailability := []operatorv1.GenerationStatus{ | |||
There was a problem hiding this comment.
you want this to come from your actual status. Compare to https://github.com/openshift/cluster-openshift-apiserver-operator/blob/master/pkg/operator/workloadcontroller/workload_controller_openshiftapiserver_v311_00.go#L280
There was a problem hiding this comment.
@deads2k we are using "github.com/openshift/api/operator/v1alpha1" not "github.com/openshift/api/operator/v1" , where the operator status does not contain the generations field ->
https://github.com/openshift/api/blob/master/operator/v1alpha1/types.go#L105-L122
That's why are we need to constructing it this way.
There was a problem hiding this comment.
We will migrate to operator/v1 in a follow-on if that is acceptable.
jhadvig
force-pushed
the
new-version-bump
branch
from
539518b
to
5840669
Compare
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
@benjaminapetersen here is the version bump PR, splitted into separate commits.
Reporting the operator status will be following a followUp
@spadgett fyi