Console Config & Operator Config client additions #130
Conversation
openshift-ci-robot
added
approved
|
@benjaminapetersen: GitHub didn't allow me to assign the following users: again. Note that only openshift members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I'm still not seeing the config-operator console CRD in the release payload :( |
|
/retest |
|
The manifest is there! /retest |
| if errors.IsNotFound(err) && CreateDefaultConsoleFlag { | ||
| return c.operatorClient.Create(c.defaultConsole()) | ||
| if _, err := c.operatorConfigClient.Create(c.defaultConsoleOperatorConfig()); err != nil { | ||
| logrus.Errorf("No console operator config found. Creating. %v \n", err) |
There was a problem hiding this comment.
@spadgett agree, this is probably better.
| consoleConfig, err := c.consoleConfigClient.Get(api.ResourceName, metav1.GetOptions{}) | ||
| if errors.IsNotFound(err) && CreateDefaultConsoleFlag { | ||
| if _, err := c.consoleConfigClient.Create(c.defaultConsoleConfig()); err != nil { | ||
| logrus.Errorf("No console config found. Creating. %v \n", err) |
There was a problem hiding this comment.
log & return the error.
|
It wasnt, then it was, then it wasn't.... Very weird |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Same as #129! With new and improve release payloads! (hopefully)
This PR clears the way for:
Which can be done as follow-ons.