Add ManagementStateController #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/L
|
/retest I would expect some failures, but this was a lot of flakes. |
benjaminapetersen
force-pushed
the
controllers/management-state
branch
from
9be507b
to
caad7e8
Compare
jhadvig
requested changes
Jul 30, 2019
benjaminapetersen
force-pushed
the
controllers/management-state
branch
from
caad7e8
to
5cc5c9c
Compare
openshift-ci-robot
added
size/M
benjaminapetersen
force-pushed
the
controllers/management-state
branch
from
5cc5c9c
to
b92e5be
Compare
|
@jhadvig should be ready for another pass. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
ManagementStateControllerto handlestatusmessages on the operator rather than handle these manually. This ensures we are consistent with other operators. Note that it does not actually handleManagementStatein terms of sync loop./assign @jhadvig