bug 1772759: fix console operator panic when RouterCAValidationDegraded #355

benjaminapetersen · 2019-11-26T20:50:48Z

Reverts router-ca changes in #328.
Not sure yet if this is the direction we want to go, considering openshift/enhancements#126.

I suspect that some of this code can return in a future PR. We will likely not need the resource-syncer, and instead will be able to annotate a new configmap with the appropriate router-ca annotation to get it injected like the proxy. Then we can assess if it exists & mount in the deployment, or not.

/assign @spadgett @jhadvig

This reverts commit 9768455.

openshift-ci-robot · 2019-11-26T20:50:50Z

@benjaminapetersen: This pull request references Bugzilla bug 1772759, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

bug 1772759: fix console operator panic when RouterCAValidationDegraded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

benjaminapetersen · 2019-11-26T20:52:05Z

pkg/console/starter/starter.go

@@ -259,6 +242,9 @@ func RunOperator(ctx *controllercmd.ControllerContext) error {
 			"Progressing",
 			"Available",
 			// "Faililng"
+			// added in 4.3, can remove in 4.4, to ensure operators running 4.3.x are not wedged.


I'm not sure if this change is strictly necessary. These were new conditions with the router-ca sync commit within the 4.3 time frame, so if the code is not running in production we can ignore.

yeah not sure we need this change, if not would rather not add it...

I would take this out, and we can backport the revert to 4.3.

openshift-ci-robot · 2019-11-26T20:53:41Z

@benjaminapetersen: This pull request references Bugzilla bug 1772759, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

bug 1772759: fix console operator panic when RouterCAValidationDegraded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-11-26T20:55:27Z

@benjaminapetersen: This pull request references Bugzilla bug 1772759, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

bug 1772759: fix console operator panic when RouterCAValidationDegraded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jhadvig · 2019-11-29T22:10:45Z

/retest

benjaminapetersen · 2019-12-02T15:23:48Z

/retest

jhadvig

/lgtm

openshift-bot · 2019-12-02T16:20:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2019-12-02T16:26:37Z

/hold

I'd remove the second commit

spadgett · 2019-12-02T17:59:03Z

pkg/console/starter/starter.go

@@ -242,6 +242,9 @@ func RunOperator(ctx *controllercmd.ControllerContext) error {
 			"Progressing",
 			"Available",
 			// "Faililng"


Not for this PR, but it looks like we can remove these now?

Yeah we should eliminate.

benjaminapetersen · 2019-12-02T20:11:00Z

Removed the second commit.

spadgett

/lgtm

spadgett · 2019-12-02T20:15:44Z

/cherrypick release-4.3

openshift-cherrypick-robot · 2019-12-02T20:15:45Z

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2019-12-02T20:15:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [benjaminapetersen,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spadgett · 2019-12-02T20:15:58Z

/hold cancel

spadgett · 2019-12-02T20:16:53Z

/bugzilla refresh

openshift-ci-robot · 2019-12-02T20:16:58Z

@spadgett: This pull request references Bugzilla bug 1772759, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett · 2019-12-02T20:18:19Z

/retest

openshift-bot · 2019-12-02T22:50:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-02T23:29:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-03T00:20:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-03T00:33:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-03T01:38:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-03T02:57:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-03T03:09:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-03T04:14:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-03T04:28:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-03T05:32:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-03T05:47:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-03T06:50:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-03T07:42:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2019-12-03T07:57:26Z

@benjaminapetersen: All pull requests linked via external trackers have merged. Bugzilla bug 1772759 has been moved to the MODIFIED state.

In response to this:

bug 1772759: fix console operator panic when RouterCAValidationDegraded

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2019-12-03T07:57:39Z

@spadgett: new pull request created: #358

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Revert "Bug 1764704: Sync router-ca to the console namespace"

963e90c

This reverts commit 9768455.

openshift-ci-robot assigned jhadvig and spadgett Nov 26, 2019

openshift-ci-robot requested review from jhadvig and spadgett November 26, 2019 20:51

benjaminapetersen commented Nov 26, 2019

View reviewed changes

jhadvig approved these changes Dec 2, 2019

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2019

spadgett reviewed Dec 2, 2019

View reviewed changes

benjaminapetersen force-pushed the router-ca/rollback-change-to-sync-to-console-namespace branch from 311fc1f to 963e90c Compare December 2, 2019 20:10

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2019

spadgett approved these changes Dec 2, 2019

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2019

benjaminapetersen mentioned this pull request Dec 2, 2019

Remove stale conditions from RemoveStaleConditionsController() #356

Merged

spadgett added this to the v4.4 milestone Dec 2, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2019

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 2, 2019

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 2, 2019

openshift-merge-robot merged commit b11c5cd into openshift:master Dec 3, 2019

openshift-cherrypick-robot mentioned this pull request Dec 3, 2019

[release-4.3] bug 1778930: fix console operator panic when RouterCAValidationDegraded #358

Merged

bug 1772759: fix console operator panic when RouterCAValidationDegraded #355

bug 1772759: fix console operator panic when RouterCAValidationDegraded #355

Conversation

benjaminapetersen commented Nov 26, 2019 • edited

openshift-ci-robot commented Nov 26, 2019

benjaminapetersen Nov 26, 2019

Choose a reason for hiding this comment

jhadvig Nov 29, 2019

Choose a reason for hiding this comment

spadgett Dec 2, 2019

Choose a reason for hiding this comment

openshift-ci-robot commented Nov 26, 2019

openshift-ci-robot commented Nov 26, 2019

jhadvig commented Nov 29, 2019

benjaminapetersen commented Dec 2, 2019

jhadvig left a comment

Choose a reason for hiding this comment

openshift-bot commented Dec 2, 2019

spadgett commented Dec 2, 2019

spadgett Dec 2, 2019

Choose a reason for hiding this comment

benjaminapetersen Dec 2, 2019

Choose a reason for hiding this comment

benjaminapetersen commented Dec 2, 2019

spadgett left a comment

Choose a reason for hiding this comment

spadgett commented Dec 2, 2019

openshift-cherrypick-robot commented Dec 2, 2019

openshift-ci-robot commented Dec 2, 2019

spadgett commented Dec 2, 2019

spadgett commented Dec 2, 2019

openshift-ci-robot commented Dec 2, 2019

spadgett commented Dec 2, 2019

openshift-bot commented Dec 2, 2019

openshift-bot commented Dec 2, 2019

openshift-bot commented Dec 3, 2019

openshift-bot commented Dec 3, 2019

openshift-bot commented Dec 3, 2019

openshift-bot commented Dec 3, 2019

openshift-bot commented Dec 3, 2019

openshift-bot commented Dec 3, 2019

openshift-bot commented Dec 3, 2019

openshift-bot commented Dec 3, 2019

openshift-bot commented Dec 3, 2019

openshift-bot commented Dec 3, 2019

openshift-bot commented Dec 3, 2019

openshift-ci-robot commented Dec 3, 2019

openshift-cherrypick-robot commented Dec 3, 2019

benjaminapetersen commented Nov 26, 2019 •

edited