Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1764316: Backport metrics_test.go [Release-4.2] #359

Conversation

benjaminapetersen
Copy link
Contributor

Ensure the console_url is available on the /metrics endpoint.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 4, 2019
@openshift-ci-robot
Copy link
Contributor

@benjaminapetersen: This pull request references Bugzilla bug 1764316, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1764316: Backport metrics_test.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2019
@benjaminapetersen
Copy link
Contributor Author

/assign @jhadvig

@benjaminapetersen
Copy link
Contributor Author

/retest

     metrics_test.go:185: route for metrics: https://metrics-openshift-console-operator.apps.ci-op-q5nfip1p-536f7.origin-ci-int-aws.dev.rhcloud.com/metrics
    metrics_test.go:191: route to /metrics: (https://metrics-openshift-console-operator.apps.ci-op-q5nfip1p-536f7.origin-ci-int-aws.dev.rhcloud.com/metrics)
    metrics_test.go:58: fetching metrics url.... https://metrics-openshift-console-operator.apps.ci-op-q5nfip1p-536f7.origin-ci-int-aws.dev.rhcloud.com/metrics
    metrics_test.go:60: fetching /metrics data...
    metrics_test.go:97: http error: 503 Service Unavailable 

Hmm.

@jhadvig
Copy link
Member

jhadvig commented Dec 5, 2019

Same issue :( Dont think its a flake.

@benjaminapetersen
Copy link
Contributor Author

Yup, several issues around the route:

# early on, but resolves
E1205 04:27:09.933682       1 status.go:71] RouteSyncProgressing FailedHost route is not available at canonical host []
E1205 04:27:09.937611       1 status.go:118] status update error: Operation cannot be fulfilled on consoles.operator.openshift.io "cluster": the object has been modified; please apply your changes to the latest version and try again
E1205 04:27:09.937638       1 controller.go:129] {Console Console} failed with: route is not available at canonical host []
# ...
"openshift-config-managed" "console-public"}]
E1205 04:43:22.506025       1 status.go:71] RouteSyncProgressing InvalidRoute route is invalid, correcting route state
E1205 04:43:22.512379       1 controller.go:129] {Console Console} failed with: route is invalid, correcting route state
# ...
I1205 04:43:23.204989       1 event.go:209] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-console-operator", Name:"console-operator", UID:"72277379-1717-11ea-86c3-0ac54aa6d1e1", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'OperatorStatusChanged' Status for clusteroperator/console changed: Progressing message changed from "RouteSyncProgressing: route is invalid, correcting route state" to "SyncLoopRefreshProgressing: Changes made during sync updates, additional sync expected."

@benjaminapetersen benjaminapetersen changed the title Bug 1764316: Backport metrics_test.go Bug 1764316: Backport metrics_test.go [Release-4.2] Dec 10, 2019
@jhadvig
Copy link
Member

jhadvig commented Feb 17, 2020

/retest

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 17, 2020
@openshift-ci-robot
Copy link
Contributor

@benjaminapetersen: This pull request references Bugzilla bug 1764316, which is invalid:

  • expected dependent Bugzilla bug 1780180 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1764316: Backport metrics_test.go [Release-4.2]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@benjaminapetersen
Copy link
Contributor Author

Closing htis and the bug. The effort & risk for a 4.2 backport is too high (even if it is just a test).

@openshift-ci-robot
Copy link
Contributor

@benjaminapetersen: This pull request references Bugzilla bug 1764316. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1764316: Backport metrics_test.go [Release-4.2]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants