Bug 1784582: Added Helm CLI download links #362

pedjak · 2019-12-10T18:22:37Z

This PR adds to OpenShift Console the additional Helm CLI download link(s).

pedjak · 2019-12-10T18:29:25Z

After merging this request, the CLI download page will look as above.

pedjak · 2019-12-10T18:36:50Z

/assign @benjaminapetersen

sbose78 · 2019-12-10T19:07:17Z

CC @siamaksade @bparees @soltysh

manifests/07-downloads-helm.yaml

pedjak · 2019-12-11T11:10:37Z

/retest

pedjak · 2019-12-11T11:37:58Z

It looks that tests are failing due to infra issues:

Error 400: The number of members in the policy (1,501) is larger than the maximum allowed size 1,500., badRequest"

How to make them pass?

pedjak · 2019-12-11T15:04:03Z

/retest

jhadvig

The PR itself looks good 👍
Please address the working suggested in https://github.com/openshift/console-operator/pull/362/files#r356387619 so we can merge.

@benjaminapetersen thoughts ?

sbose78 · 2019-12-12T23:32:58Z

manifests/07-downloads-helm.yaml

+  description: |
+    Helm 3 is a package manager for Kubernetes applications which enables defining,
+    installing and upgrading applications packaged as Helm Charts.
+    Helm 3 is in <a href=https://access.redhat.com/support/offerings/techpreview>Technology Preview</a> feature on OpenShift 4.


Predrag, have you verified that it shows up as a clickable URL?

Yes, see the screenshot attached above,

either:
Helm 3 is in Technology Preview on OpenShift
or
Helm 3 is a Technology Preview feature on Openshift

but Helm 3 is in Technology Preview feature on OpenShift is not a grammatically correct sentence.

There is also an e2e suite in console that verifies the CLIDownload links. You could add a few lines here as well:

https://github.com/openshift/console/blob/e3080430f4ac297619b57062410c461333e62c9f/frontend/integration-tests/tests/crd-extensions.scenario.ts#L15

bparees · 2019-12-13T00:05:48Z

@sbose78 @pedjak https://mirror.openshift.com/pub/openshift-v4/helm/latest is not a valid link. When do you plan to have the content there? I do not want us to ship ocp4 with a broken link in the console.

also i would expect the url to be something under https://mirror.openshift.com/pub/openshift-v4/clients/

bparees · 2019-12-13T00:05:58Z

/hold

pedjak · 2019-12-13T00:23:28Z

@bparees thanks, correct the grammar issue and changed the download link to https://mirror.openshift.com/pub/openshift-v4/clients/helm/latest My understanding is that we want to deliver helm with 4.3 release, right @sbose78 ?

bparees · 2019-12-13T01:08:30Z

/hold cancel
@benjaminapetersen @spadgett i think this can merge if you're ok with it, assuming we can get confirmation the helm binary will be there by the time 4.3 GAs.

sbose78 · 2019-12-13T01:41:49Z

Yes, that's correct, Predrag & Ben. The binary would be there when 4.3 releases.

benjaminapetersen · 2019-12-13T15:45:15Z

You could also update the tests
https://github.com/openshift/console-operator/blob/master/test/e2e/downloads_test.go#L24
To prove that the link functions in 4.3/4.4.

manifests/07-downloads-helm.yaml

benjaminapetersen · 2019-12-13T15:48:55Z

We should also squash the commits before merge.

benjaminapetersen

Just a few comments. Definitely a squash, and ideally add to the tests.

pedjak · 2019-12-16T16:32:07Z

@benjaminapetersen I would add the check to the tests, but we still do not have the binaries ready for the download, or you mean that we should only check if the link gets rendered? BTW, Checking ODO links is also not a part of the test atm.

I have squashed the commits.

manifests/07-downloads-helm.yaml

pedjak · 2019-12-17T16:22:33Z

@spadgett - I have included the proposed fixes, thanks for your feedback. I cannot add the test at the moment because we do not have binaries ready for download. Speaking about the links, should we add actually individual DL links for each of the platforms (linux, osx, windows) or leave it as it is. I have followed ODO approach, @siamaksade what do you think?

Speaking about testing, the existing TestDownloadsEndpoint() checks only if oc can be downloaded. Do we have somewhere browser tests that check if the page is properly rendered? Do we use https://github.com/tebeka/selenium or similar?

bparees · 2019-12-17T16:26:20Z

fyi we are passed code freeze, this did not merge. Barring a request for an extremely urgent exception, this will not ship in 4.3.0GA, we can consider including in in the first z-stream.

openshift-bot · 2019-12-20T04:27:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T04:41:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T05:44:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T05:58:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T07:03:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T07:16:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T09:13:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T09:26:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T10:30:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T10:56:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T11:49:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T12:02:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T13:07:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T13:20:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T14:25:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T15:04:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T15:43:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-20T15:56:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

bparees · 2019-12-20T17:03:56Z

/hold

please look into these failures.
https://prow.svc.ci.openshift.org/job-history/origin-ci-test/pr-logs/directory/pull-ci-openshift-console-operator-master-e2e-aws-console

pedjak · 2019-12-23T17:33:24Z

@bparees the test were passing the last time here but the only big difference to the actual PR is that Tech Preview link was declared using <a href.../> syntax.

benjaminapetersen · 2019-12-23T17:44:48Z

The console e2e test suite is struggling atm, we are definitely looking into it.

spadgett · 2020-01-02T17:14:06Z

We're working on a fix for the console e2e tests in openshift/console#3847

spadgett · 2020-01-03T00:55:22Z

/hold cancel
/retest
CI is fixed

openshift-bot · 2020-01-03T00:58:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-01-03T03:57:01Z

@pedjak: All pull requests linked via external trackers have merged. Bugzilla bug 1784582 has been moved to the MODIFIED state.

In response to this:

Bug 1784582: Added Helm CLI download links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-01-03T03:57:21Z

@pedjak: new pull request created: #363

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 10, 2019

openshift-ci-robot requested review from jhadvig and spadgett December 10, 2019 18:23

openshift-ci-robot assigned benjaminapetersen Dec 10, 2019

bparees reviewed Dec 10, 2019

View reviewed changes

manifests/07-downloads-helm.yaml Outdated Show resolved Hide resolved

jhadvig requested changes Dec 12, 2019

View reviewed changes

sbose78 reviewed Dec 12, 2019

View reviewed changes

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2019

benjaminapetersen reviewed Dec 13, 2019

View reviewed changes

manifests/07-downloads-helm.yaml Outdated Show resolved Hide resolved

benjaminapetersen suggested changes Dec 13, 2019

View reviewed changes

pedjak force-pushed the APPSVC-60 branch from eed8d91 to 46f20ef Compare December 16, 2019 16:31

spadgett reviewed Dec 16, 2019

View reviewed changes

manifests/07-downloads-helm.yaml Outdated Show resolved Hide resolved

manifests/07-downloads-helm.yaml Outdated Show resolved Hide resolved

manifests/07-downloads-helm.yaml Outdated Show resolved Hide resolved

pedjak force-pushed the APPSVC-60 branch from 46f20ef to bb73370 Compare December 17, 2019 16:11

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2020

openshift-merge-robot merged commit 3998db4 into openshift:master Jan 3, 2020

openshift-cherrypick-robot mentioned this pull request Jan 3, 2020

Bug 1785310: Added Helm CLI download links [release-4.3] #363

Merged

Bug 1784582: Added Helm CLI download links #362

Bug 1784582: Added Helm CLI download links #362

Conversation

pedjak commented Dec 10, 2019 • edited

pedjak commented Dec 10, 2019

pedjak commented Dec 10, 2019

sbose78 commented Dec 10, 2019

pedjak commented Dec 11, 2019

pedjak commented Dec 11, 2019

pedjak commented Dec 11, 2019

jhadvig left a comment

Choose a reason for hiding this comment

sbose78 Dec 12, 2019 • edited

Choose a reason for hiding this comment

pedjak Dec 12, 2019

Choose a reason for hiding this comment

bparees Dec 13, 2019

Choose a reason for hiding this comment

benjaminapetersen Dec 13, 2019

Choose a reason for hiding this comment

bparees commented Dec 13, 2019

bparees commented Dec 13, 2019

pedjak commented Dec 13, 2019

bparees commented Dec 13, 2019

sbose78 commented Dec 13, 2019

benjaminapetersen commented Dec 13, 2019

benjaminapetersen commented Dec 13, 2019

benjaminapetersen left a comment

Choose a reason for hiding this comment

pedjak commented Dec 16, 2019

pedjak commented Dec 17, 2019

bparees commented Dec 17, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

openshift-bot commented Dec 20, 2019

bparees commented Dec 20, 2019

pedjak commented Dec 23, 2019

benjaminapetersen commented Dec 23, 2019

spadgett commented Jan 2, 2020

spadgett commented Jan 3, 2020

openshift-bot commented Jan 3, 2020

openshift-ci-robot commented Jan 3, 2020

openshift-cherrypick-robot commented Jan 3, 2020

pedjak commented Dec 10, 2019 •

edited

sbose78 Dec 12, 2019 •

edited