New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RBAC for console backend to request openshift-config-managed configmaps #366
Conversation
kind: Role | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
metadata: | ||
name: managed-configmap-reader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So currently we have:
oc get role -n openshift-config-managed
NAME AGE
console-operator 28h
console-public 28h
machine-approver 28h
For this reason I'm inclined to name it console-configmap-reader
. Since its in openshift-config-managed
namespace. That would give us:
oc get role -n openshift-config-managed
NAME AGE
console-configmap-reader 28h
console-operator 28h
console-public 28h
machine-approver 28h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did speak about console-public
being somewhat "different" as its more for other components being able to get the console-public
configmap so those components can oc get configmap console-public -n openshift-config-managed --template '{{.data.consoleURL}}'
and use the console url value. This is probably fine.
@benjaminapetersen PR updated, set the console podSpec to use the |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding:
Role
for GETting ConfigMaps from theopenshift-config-managed
namespace. Haven't found any existing Role on the cluster that would be suitable.ServiceAccount
for the console, since there are only default ServiceAccounts in theopenshift-console
namespaceRoleBinding
- for binding the addedRole
andServiceAccount
Story: https://issues.redhat.com/browse/CONSOLE-1993
/assign @benjaminapetersen