Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to go mods, use openshift/build-machinery-go for building #406

Merged
merged 4 commits into from Apr 3, 2020
Merged

Move to go mods, use openshift/build-machinery-go for building #406

merged 4 commits into from Apr 3, 2020
+16,872 −3,656,207

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Apr 2, 2020

No description provided.

@stlaz
Copy link
Member Author

stlaz commented Apr 2, 2020

You appear to be using go 1.12 for your builds is why all builds fail, I thought 1.13 was a requirement since kube 1.17 (or perhaps even earlier)

@stlaz
Copy link
Member Author

stlaz commented Apr 2, 2020

depends on openshift/release#8087

jhadvig
jhadvig approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes by running the tests and also build and docker build
Should be good 👍
We need to merge openshift/release#8087 first though

@benjaminapetersen
Copy link
Contributor

/retest

openshift/release#8087 merged

@jhadvig
Copy link
Member

jhadvig commented Apr 2, 2020

/test e2e-aws-operator

1 similar comment
@jhadvig
Copy link
Member

jhadvig commented Apr 2, 2020

/test e2e-aws-operator

@jhadvig
Copy link
Member

jhadvig commented Apr 2, 2020 

=== RUN   TestEditManagedRoute
--- FAIL: TestEditManagedRoute (243.28s)
    managed_test.go:13: waiting for setup to reach settled state...
    util.go:72: patching TargetPort on the console Route
    util.go:79: polling for patched TargetPort on the console Route
    managed_test.go:17: waiting for cleanup to reach settled state...
    console-operator.go:369: waited 10 seconds to reach settled state...
    console-operator.go:369: waited 30 seconds to reach settled state...
    console-operator.go:369: waited 60 seconds to reach settled state...
    console-operator.go:369: waited 90 seconds to reach settled state...
    console-operator.go:369: waited 120 seconds to reach settled state...
    managed_test.go:17: operator has not reached settled state in 4m0s attempts due to [RouteHealthDegraded] - timed out waiting for the condition

@jhadvig
Copy link
Member

jhadvig commented Apr 2, 2020

/test e2e-aws-operator

@jhadvig
Copy link
Member

jhadvig commented Apr 3, 2020

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 3, 2020 •
edited

@stlaz: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/integration f2b4688 link /test integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stlaz
Copy link
Member Author

stlaz commented Apr 3, 2020

/retest

@jhadvig
Copy link
Member

jhadvig commented Apr 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2020
benjaminapetersen
benjaminapetersen approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

nice! appreciate this.

@benjaminapetersen benjaminapetersen added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, jhadvig, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 63c80bf into openshift:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@jhadvig jhadvig jhadvig approved these changes

Assignees

@benjaminapetersen benjaminapetersen

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stlaz @benjaminapetersen @jhadvig @openshift-ci-robot @openshift-merge-robot