Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1823719: Remove "Technology Preview" reference from Helm CLI download description #408

Merged
merged 1 commit into from Apr 9, 2020
Merged

Bug 1823719: Remove "Technology Preview" reference from Helm CLI download description #408

merged 1 commit into from Apr 9, 2020

Conversation

pedjak
Copy link
Contributor

@pedjak pedjak commented Apr 3, 2020

Helm 3 becomes GA with OpenShift 4.4

@pedjak
Copy link
Contributor Author

pedjak commented Apr 3, 2020

/retest

@pedjak
Copy link
Contributor Author

pedjak commented Apr 8, 2020

/assign @benjaminapetersen

please approve

jhadvig
jhadvig approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2020
benjaminapetersen
benjaminapetersen approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, jhadvig, pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2020
@pedjak
Copy link
Contributor Author

pedjak commented Apr 9, 2020

/retest

1 similar comment
@pedjak
Copy link
Contributor Author

pedjak commented Apr 9, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 24016cc into openshift:master Apr 9, 2020
@pedjak
Copy link
Contributor Author

pedjak commented Apr 14, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 14, 2020
Merged
@openshift-cherrypick-robot
Copy link

@pedjak: new pull request created: #414

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pedjak
Copy link
Contributor Author

pedjak commented Apr 14, 2020

/retitle Bug 1823719: Remove "Technology Preview" reference from Helm CLI download description

@openshift-ci-robot openshift-ci-robot changed the title Remove "Technology Preview" reference from Helm CLI download description Bug 1823719: Remove "Technology Preview" reference from Helm CLI download description Apr 14, 2020
@openshift-ci-robot
Copy link
Contributor

@pedjak: All pull requests linked via external trackers have merged: . Bugzilla bug 1823719 has been moved to the MODIFIED state.

In response to this:

Bug 1823719: Remove "Technology Preview" reference from Helm CLI download description

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@jhadvig jhadvig jhadvig approved these changes

Assignees

@benjaminapetersen benjaminapetersen

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pedjak @openshift-ci-robot @openshift-bot @openshift-cherrypick-robot @benjaminapetersen @jhadvig @openshift-merge-robot