Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1826716: RBAC to authorise service account to list CRDs #413

Merged
merged 1 commit into from Apr 22, 2020
Merged

Bug 1826716: RBAC to authorise service account to list CRDs #413

merged 1 commit into from Apr 22, 2020
+29 −0

Conversation

abhi-kn
Copy link
Contributor

@abhi-kn abhi-kn commented Apr 13, 2020

https://issues.redhat.com/browse/ODC-3398

New endpoint is being added in console backend to list knative event source CRDs.
Ref: openshift/console#4945.

In order to allow an unprivileged user to get this information without read access to CRDs, new RBAC has been added here to authorise service account to list CRDs.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2020
@abhi-kn
Copy link
Contributor Author

abhi-kn commented Apr 13, 2020

/assign @spadgett

@abhi-kn abhi-kn mentioned this pull request Apr 13, 2020
Merged
jhadvig
jhadvig reviewed Apr 14, 2020
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good. Not suer if anything additional is needed in order to make it available to unprivileged user to list the CRDs. @benjaminapetersen thoughts ?

manifests/03-rbac-role-cluster.yaml Show resolved Hide resolved
spadgett
spadgett reviewed Apr 14, 2020
View reviewed changes
manifests/03-rbac-role-cluster.yaml Outdated Show resolved Hide resolved
manifests/04-rbac-rolebinding-cluster.yaml Outdated Show resolved Hide resolved
manifests/04-rbac-rolebinding-cluster.yaml Outdated Show resolved Hide resolved
@abhi-kn abhi-kn changed the title [WIP] RBAC to authorise service account to list CRDs RBAC to authorise service account to list CRDs Apr 14, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2020
@abhi-kn
Copy link
Contributor Author

abhi-kn commented Apr 14, 2020

/retest

1 similar comment
@abhi-kn
Copy link
Contributor Author

abhi-kn commented Apr 15, 2020

/retest

@benjaminapetersen
Copy link
Contributor

/approve

/retest

unrelated things i think.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2020
@abhi-kn
Copy link
Contributor Author

abhi-kn commented Apr 16, 2020

/retest

6 similar comments
@abhi-kn
Copy link
Contributor Author

abhi-kn commented Apr 16, 2020

/retest

@abhi-kn
Copy link
Contributor Author

abhi-kn commented Apr 17, 2020

/retest

@abhi-kn
Copy link
Contributor Author

abhi-kn commented Apr 17, 2020

/retest

@abhi-kn
Copy link
Contributor Author

abhi-kn commented Apr 17, 2020

/retest

@abhi-kn
Copy link
Contributor Author

abhi-kn commented Apr 17, 2020

/retest

@abhi-kn
Copy link
Contributor Author

abhi-kn commented Apr 17, 2020

/retest

jhadvig
jhadvig approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@abhi-kn
Copy link
Contributor Author

abhi-kn commented Apr 21, 2020

/retest

jhadvig
jhadvig requested changes Apr 21, 2020
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional feedback, regarding structure and naming.

manifests/03-rbac-role-cluster.yaml Show resolved Hide resolved
manifests/03-rbac-role-cluster.yaml Show resolved Hide resolved
manifests/04-rbac-rolebinding-cluster.yaml Show resolved Hide resolved
manifests/04-rbac-rolebinding-cluster.yaml Show resolved Hide resolved
manifests/03-rbac-role-cluster.yaml Show resolved Hide resolved
@abhi-kn
Copy link
Contributor Author

abhi-kn commented Apr 21, 2020

/retest

@jhadvig
Copy link
Member

jhadvig commented Apr 22, 2020 •
edited

@abhi-kn at this point we need a BZ for the ci-bot to merge the PR

@jhadvig
Copy link
Member

jhadvig commented Apr 22, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhi-kn, benjaminapetersen, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@abhi-kn abhi-kn changed the title RBAC to authorise service account to list CRDs Bug 1826716: RBAC to authorise service account to list CRDs Apr 22, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/unspecified bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 22, 2020
@openshift-ci-robot
Copy link
Contributor

@abhi-kn: This pull request references Bugzilla bug 1826716, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1826716: RBAC to authorise service account to list CRDs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 04ecd9f into openshift:master Apr 22, 2020
@openshift-ci-robot
Copy link
Contributor

@abhi-kn: All pull requests linked via external trackers have merged: openshift/console-operator#413. Bugzilla bug 1826716 has been moved to the MODIFIED state.

In response to this:

Bug 1826716: RBAC to authorise service account to list CRDs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett left review comments

@jhadvig jhadvig jhadvig approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

Assignees

@spadgett spadgett

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@abhi-kn @benjaminapetersen @jhadvig @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot