Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1828272: Update 'Learning Portal' console helpMenu url to track where request it is coming from #419

Merged
merged 1 commit into from Apr 27, 2020
Merged

Bug 1828272: Update 'Learning Portal' console helpMenu url to track where request it is coming from #419

merged 1 commit into from Apr 27, 2020

Conversation

dtaylor113
Copy link
Contributor

Jan Kleinert
I'd like to append:
?ref=webconsole
That way we can filter for this traffic without stomping on any referral info

@dtaylor113 dtaylor113 changed the title Update 'Learning Portal' console helpMenu url so they can track where request it is coming from Update 'Learning Portal' console helpMenu url to track where request it is coming from Apr 23, 2020
jankleinert
jankleinert approved these changes Apr 23, 2020
View reviewed changes
Copy link

@jankleinert jankleinert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dtaylor113
Copy link
Contributor Author

/retest

spadgett
spadgett approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, jankleinert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2020
@spadgett spadgett added this to the v4.5 milestone Apr 24, 2020
@spadgett
Copy link
Member

/retest

@benjaminapetersen
Copy link
Contributor

Should this be added to the blog link as well?

kind: ConsoleLink
metadata:
  name: openshift-blog
spec:
  href: 'https://blog.openshift.com'

@dtaylor113 dtaylor113 changed the title Update 'Learning Portal' console helpMenu url to track where request it is coming from Bug 1828272: Update 'Learning Portal' console helpMenu url to track where request it is coming from Apr 27, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 27, 2020
@dtaylor113
Copy link
Contributor Author

/bugzilla refresh
/retest

@openshift-ci-robot
Copy link
Contributor

@dtaylor113: This pull request references Bugzilla bug 1828272, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift openshift deleted a comment from openshift-ci-robot Apr 27, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit df170d4 into openshift:master Apr 27, 2020
@openshift-ci-robot
Copy link
Contributor

@dtaylor113: All pull requests linked via external trackers have merged: openshift/console-operator#419. Bugzilla bug 1828272 has been moved to the MODIFIED state.

In response to this:

Bug 1828272: Update 'Learning Portal' console helpMenu url to track where request it is coming from

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankleinert jankleinert jankleinert approved these changes

@spadgett spadgett spadgett approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dtaylor113 @openshift-ci-robot @spadgett @benjaminapetersen @openshift-bot @jankleinert @openshift-merge-robot