Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deliver HelmChartRepository CRD as the part of the payload #453

Merged
merged 2 commits into from Jul 30, 2020
Merged

deliver HelmChartRepository CRD as the part of the payload #453

merged 2 commits into from Jul 30, 2020

Conversation

pedjak
Copy link
Contributor

@pedjak pedjak commented Jul 24, 2020 •
edited

/hold

we need to get first openshift/api#598 in.

pedjak
pedjak commented Jul 24, 2020
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@pedjak
Copy link
Contributor Author

pedjak commented Jul 24, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2020
@sbose78
Copy link

sbose78 commented Jul 27, 2020

/retest

1 similar comment
@pedjak
Copy link
Contributor Author

pedjak commented Jul 28, 2020

/retest

@pedjak
Copy link
Contributor Author

pedjak commented Jul 30, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2020
@pedjak
Copy link
Contributor Author

pedjak commented Jul 30, 2020

/cc @spadgett

spadgett
spadgett approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 30, 2020
@sbose78
Copy link

sbose78 commented Jul 30, 2020

/lgtm

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, pedjak, sbose78, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pedjak
Copy link
Contributor Author

pedjak commented Jul 30, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sbose78
Copy link

sbose78 commented Jul 30, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9464842 into openshift:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jhadvig jhadvig jhadvig approved these changes

Assignees

@sbose78 sbose78

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pedjak @sbose78 @openshift-bot @openshift-ci-robot @spadgett @jhadvig @openshift-merge-robot