Bug 1873414: Move deployment script to python3 #463
Conversation
openshift-ci-robot
added
bugzilla/severity-medium
|
@yselkowitz: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yselkowitz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is used by the downloads-deployment serve.py script: openshift/console-operator#463
yselkowitz
changed the title
openshift-ci-robot
removed
the
bugzilla/severity-medium
|
@yselkowitz: This pull request references Bugzilla bug 1873414, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/severity-urgent
|
/test unit |
|
openshift/oc#538 probably needs to land first for CI to pass. |
|
openshift/images#34 needs to land first for CI to pass here. |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-gcp |
| @@ -135,7 +135,7 @@ spec: | |||
| for directory in directories: | |||
| write_index( | |||
| path=os.path.join(root, directory, 'index.html'), | |||
| message='<p>Directory listings are disabled. See <a href="">here</a> for available content.</p>'.format(root_link), | |||
| message='<p>Directory listings are disabled. See <a href="{}">here</a> for available content.</p>'.format(root_link), | |||
There was a problem hiding this comment.
Unrelated, but thanks for this fix :)
There was a problem hiding this comment.
Found this testing the script with python3, but yes, it was broken before too. The root index.html still doesn't work as intended though, nor did it before, but I'm not sure how to fix it yet. (Nothing to do with this PR though.)
There was a problem hiding this comment.
@spadgett something to potentially clean up in the future
|
@jupierce removed the ci-op-633tn047 project, which may have cached stale images. Testing again (hopefully with freshly-built images): /retest |
|
@yselkowitz: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
passed everything that matters, merging to unblock CI. |
|
@yselkowitz: All pull requests linked via external trackers have merged: Bugzilla bug 1873414 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.