New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespace and role resources for user settings #479
Conversation
/retest |
@spadgett Can you take a look or assign this issue to someone who can review this change and openshift/console#7095? |
/retest |
kind: Role | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
metadata: | ||
name: console-user-settings-role-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets drop the -operator
suffix. It's a bit confusing since there is actually no operator that would be handling the openshift-console-user-settings
namespace.
Also most of the time we are not adding the -role
suffix as well since the resource is Role
itself.
In case we want a name that would reflect the role, I would rather go with console-user-settings-admin
Thanks @jhadvig for reviewing this. Applied all your recommendations 👍 |
Rebased and added a new label:
/retest |
@jerolimov noticed you added the |
@jhadvig You're right 👍 , based on this discussion in slack I removed the labels again. |
/retest |
3 similar comments
/retest |
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Fixes:
https://issues.redhat.com/browse/ODC-4755
Analysis / Root cause:
Based on the User Settings for OpenShift Console enhancement proposal we want to create a
ConfigMap
for each individual user in the namespaceopenshift-console-user-settings
We create a
ConfigMap
with a service account from the console bridge, see PR openshift/console#7095. For this we need that the namespace, role and rolebinding which is added in this PR.Solution Description:
openshift-console-user-settings
console-user-settings-role-operator
to allow the ServiceAccount to get, list, create, update and delete Role, RoleBinding and ConfigMap in this new namespace.