Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace and role resources for user settings #479

Merged
merged 1 commit into from Nov 24, 2020

Conversation

jerolimov
Copy link
Member

@jerolimov jerolimov commented Nov 5, 2020

Fixes:
https://issues.redhat.com/browse/ODC-4755

Analysis / Root cause:
Based on the User Settings for OpenShift Console enhancement proposal we want to create a ConfigMap for each individual user in the namespace openshift-console-user-settings

We create a ConfigMap with a service account from the console bridge, see PR openshift/console#7095. For this we need that the namespace, role and rolebinding which is added in this PR.

Solution Description:

  • Add Namespace openshift-console-user-settings
  • Add Role and RoleBinding console-user-settings-role-operator to allow the ServiceAccount to get, list, create, update and delete Role, RoleBinding and ConfigMap in this new namespace.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2020
@jerolimov
Copy link
Member Author

/retest

@jerolimov jerolimov changed the title [WIP] Add openshift-console-user-settings namespace Add openshift-console-user-settings namespace and role resources Nov 18, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2020
@jerolimov jerolimov changed the title Add openshift-console-user-settings namespace and role resources Add namespace and role resources for user settings Nov 18, 2020
@jerolimov
Copy link
Member Author

@spadgett Can you take a look or assign this issue to someone who can review this change and openshift/console#7095?

@jerolimov
Copy link
Member Author

/retest

kind: Role
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: console-user-settings-role-operator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets drop the -operator suffix. It's a bit confusing since there is actually no operator that would be handling the openshift-console-user-settings namespace.
Also most of the time we are not adding the -role suffix as well since the resource is Role itself.
In case we want a name that would reflect the role, I would rather go with console-user-settings-admin

@jerolimov
Copy link
Member Author

Thanks @jhadvig for reviewing this. Applied all your recommendations 👍

@jerolimov
Copy link
Member Author

Rebased and added a new label:

console.openshift.io/user-settings: "true"

/retest

@jhadvig
Copy link
Member

jhadvig commented Nov 19, 2020

@jerolimov noticed you added the console.openshift.io/user-setting label to all the resources. Havent found that label documented anywhere, can you please provide any info about it ?

@jerolimov
Copy link
Member Author

@jerolimov noticed you added the console.openshift.io/user-setting label to all the resources. Havent found that label documented anywhere, can you please provide any info about it ?

@jhadvig You're right 👍 , based on this discussion in slack I removed the labels again.

@jerolimov
Copy link
Member Author

/retest

3 similar comments
@jhadvig
Copy link
Member

jhadvig commented Nov 20, 2020

/retest

@jerolimov
Copy link
Member Author

/retest

@jerolimov
Copy link
Member Author

/retest

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2020
@jerolimov
Copy link
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants