Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1907280: Adds quickstart for ocs install tour #492

Merged

Conversation

vbnrh
Copy link
Contributor

@vbnrh vbnrh commented Dec 2, 2020

Depends on #490

Signed-off-by: Vineet Badrinath vbadrina@redhat.com

@vbnrh vbnrh changed the title Adds quickstart for ocs install tour [WIP] Adds quickstart for ocs install tour Dec 2, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2020
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @vbnrh. It looks like this might not have been reviewed for content. We should get that done if not.

/cc @beanh66

quickstarts/ocs-install-tour-quickstart.yaml Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
@spadgett
Copy link
Member

spadgett commented Dec 3, 2020

@bmignano @beanh66 Would you be able to help us review the quick start for content?

@vbnrh vbnrh changed the title [WIP] Adds quickstart for ocs install tour Adds quickstart for ocs install tour Dec 4, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2020
@vbnrh vbnrh force-pushed the ocs-install-tour-quickstart branch from 2d3782e to ad93672 Compare December 4, 2020 11:43
Copy link

@abigaeljamie abigaeljamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to review a few steps and provide revisions, but my UI stopped matching the instructions once I reached the step about Operator Subscription form. I sent a meeting invite to Yuval for Monday to walk through this.

quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the comments from @abigaeljamie 's comments are addressed I would also keep I on #493 cause its adding an additional annotation to the QuickStarts.
Please keep an eye on the PR and if its merged before your's PR, please add the annotation.

@vbnrh vbnrh force-pushed the ocs-install-tour-quickstart branch 2 times, most recently from 9c1b6db to 8598fb9 Compare December 7, 2020 13:41
@vbnrh
Copy link
Contributor Author

vbnrh commented Dec 7, 2020

After the comments from @abigaeljamie 's comments are addressed I would also keep I on #493 cause its adding an additional annotation to the QuickStarts.
Please keep an eye on the PR and if its merged before your's PR, please add the annotation.

@jhadvig thanks for the heads up. Do you want me to add the annotation now itself before your PR is merged ?

@vbnrh vbnrh force-pushed the ocs-install-tour-quickstart branch from 8598fb9 to fda5e95 Compare December 7, 2020 13:46
@jhadvig
Copy link
Member

jhadvig commented Dec 7, 2020

@vbnrh yes, please add it.

@vbnrh vbnrh force-pushed the ocs-install-tour-quickstart branch from fda5e95 to 24cb26b Compare December 7, 2020 14:09
@vbnrh
Copy link
Contributor Author

vbnrh commented Dec 7, 2020

@vbnrh yes, please add it.

done

@jhadvig
Copy link
Member

jhadvig commented Dec 7, 2020

Thanks @vbnrh
Will wait for final review from @abigaeljamie before tagging.

Copy link

@abigaeljamie abigaeljamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set, @yuvalgalanti ! Let me know if you have any questions 🙂 Thanks!

quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
@vbnrh vbnrh force-pushed the ocs-install-tour-quickstart branch 2 times, most recently from 4b4296f to 38757da Compare December 8, 2020 05:24
@jhadvig
Copy link
Member

jhadvig commented Dec 8, 2020

/retest

@jhadvig
Copy link
Member

jhadvig commented Dec 8, 2020

@abigaeljamie please approve the PR when you are satisfied with all the changes. Will tag for merge afterwards :)

Copy link

@abigaeljamie abigaeljamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were just a few small leftover edits that didn't make it in, so I added those again. Otherwise, it looks great!

quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
quickstarts/ocs-install-tour-quickstart.yaml Outdated Show resolved Hide resolved
Signed-off-by: Vineet Badrinath <vbadrina@redhat.com>
@vbnrh vbnrh force-pushed the ocs-install-tour-quickstart branch from 38757da to 9771783 Compare December 8, 2020 14:43
Copy link

@abigaeljamie abigaeljamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Thank you :)

@jhadvig
Copy link
Member

jhadvig commented Dec 8, 2020

/retest

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jhadvig
Copy link
Member

jhadvig commented Dec 10, 2020

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abigaeljamie, jhadvig, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jhadvig
Copy link
Member

jhadvig commented Dec 12, 2020

@vbnrh we need a BZ for this since its past feature freeze

@vbnrh vbnrh changed the title Adds quickstart for ocs install tour Bug 1907280: Adds quickstart for ocs install tour Dec 14, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Dec 14, 2020
@openshift-ci-robot
Copy link
Contributor

@vbnrh: This pull request references Bugzilla bug 1907280, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1907280: Adds quickstart for ocs install tour

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 14, 2020
@cloudbehl
Copy link

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 14, 2020
@openshift-ci-robot
Copy link
Contributor

@cloudbehl: This pull request references Bugzilla bug 1907280, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ff4e17c into openshift:master Dec 14, 2020
@openshift-ci-robot
Copy link
Contributor

@vbnrh: All pull requests linked via external trackers have merged:

Bugzilla bug 1907280 has been moved to the MODIFIED state.

In response to this:

Bug 1907280: Adds quickstart for ocs install tour

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants