New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1907280: Adds quickstart for ocs install tour #492
Bug 1907280: Adds quickstart for ocs install tour #492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
002c4c3
to
2d3782e
Compare
2d3782e
to
ad93672
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to review a few steps and provide revisions, but my UI stopped matching the instructions once I reached the step about Operator Subscription form. I sent a meeting invite to Yuval for Monday to walk through this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the comments from @abigaeljamie 's comments are addressed I would also keep I on #493 cause its adding an additional annotation to the QuickStarts.
Please keep an eye on the PR and if its merged before your's PR, please add the annotation.
9c1b6db
to
8598fb9
Compare
@jhadvig thanks for the heads up. Do you want me to add the annotation now itself before your PR is merged ? |
8598fb9
to
fda5e95
Compare
@vbnrh yes, please add it. |
fda5e95
to
24cb26b
Compare
done |
Thanks @vbnrh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All set, @yuvalgalanti ! Let me know if you have any questions 🙂 Thanks!
4b4296f
to
38757da
Compare
/retest |
@abigaeljamie please approve the PR when you are satisfied with all the changes. Will tag for merge afterwards :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were just a few small leftover edits that didn't make it in, so I added those again. Otherwise, it looks great!
Signed-off-by: Vineet Badrinath <vbadrina@redhat.com>
38757da
to
9771783
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉 Thank you :)
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abigaeljamie, jhadvig, vbnrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@vbnrh we need a BZ for this since its past feature freeze |
@vbnrh: This pull request references Bugzilla bug 1907280, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@cloudbehl: This pull request references Bugzilla bug 1907280, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@vbnrh: All pull requests linked via external trackers have merged: Bugzilla bug 1907280 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Depends on #490
Signed-off-by: Vineet Badrinath vbadrina@redhat.com