Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix consistency issues with QS displaynames and incorporate highlight… #503

Conversation

serenamarie125
Copy link
Contributor

@serenamarie125 serenamarie125 commented Feb 3, 2021

FYI @openshift/quickstart-ux-content

This fixes https://issues.redhat.com/browse/ODC-5471

Screenshot of the catalog with updated content:
Screen Shot 2021-02-03 at 5 47 34 PM

and individual screenshots of all pages showing hints:

  • Monitor

Screen Shot 2021-02-03 at 5 50 24 PM

- Install serverless

Screen Shot 2021-02-03 at 5 50 14 PM

- Install pipelines

Screen Shot 2021-02-03 at 5 50 06 PM

- Getting Started

Screen Shot 2021-02-03 at 5 49 37 PM

- Add health checks

Screen Shot 2021-02-03 at 5 49 22 PM

@bmignano
Copy link

bmignano commented Feb 4, 2021

LGTM!

@serenamarie125
Copy link
Contributor Author

@andrewballantyne @spadgett this is the last PR around Quick Starts for me this release :). Brie has tested and provided a LGTM. If you can provide your magic, that would be great. Thanks.

@christianvogt
Copy link

Changes in the diff lgtm. I didn't run them though.

@andrewballantyne
Copy link
Contributor

/lgtm

/assign @spadgett

Need Sam's approval.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2021
@spadgett
Copy link
Member

spadgett commented Feb 4, 2021

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, serenamarie125, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit c1efdfc into openshift:master Feb 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2021

@serenamarie125: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 4c0e8e0 link /test e2e-gcp
ci/prow/e2e-agnostic-upgrade 4c0e8e0 link /test e2e-agnostic-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants