Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ODF install tour #559

Merged

Conversation

vbnrh
Copy link
Contributor

@vbnrh vbnrh commented Jun 24, 2021

For 4.9 release, OCS operator will be replaced with the ODF at a higher level. Hence we would want to make sure that new install quickstart accurately represent the workflows for ODF operator.

This commit adds quickstart for installing the ODF operator and setting up the storage cluster.

Signed-off-by: Vineet Badrinath vbadrina@redhat.com

@openshift-ci openshift-ci bot requested review from jhadvig and spadgett June 24, 2021 10:47
@spadgett
Copy link
Member

@openshift/quickstart-ux-content

Copy link
Contributor

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a few changes and have some questions. Thanks for pinging me for a review!

I'd assume this should be called odf-install-tour ?

quickstarts/install-odf.yaml Show resolved Hide resolved
quickstarts/install-odf.yaml Outdated Show resolved Hide resolved
quickstarts/install-odf.yaml Show resolved Hide resolved
@spadgett
Copy link
Member

spadgett commented Jul 9, 2021

If we want to rename the resource, I believe we can now add a release.openshift.io/delete: "true" annotation to the old manifest so it's removed. We'd need to test that it's implemented. See https://github.com/openshift/enhancements/blob/ce4d303db807622687159eb9d3248285a003fabb/enhancements/update/object-removal-manifest-annotation.md

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I dont think that we can just rename the CVO managed resources. As @spadgett mentioned we should rather add the release.openshift.io/delete: "true" annotation to the old manifest so it's removed and create the new ODF install tour.

Signed-off-by: Vineet Badrinath <vbadrina@redhat.com>
@vbnrh
Copy link
Contributor Author

vbnrh commented Jul 21, 2021

@jhadvig @spadgett I have added the annotation to the older manifest and updated the PR.

Please take a look

@vbnrh vbnrh requested review from jhadvig and spadgett July 21, 2021 12:17
@vbnrh
Copy link
Contributor Author

vbnrh commented Jul 21, 2021

/test e2e-aws-operator

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, vbnrh, yuvalgalanti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 26c292f into openshift:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants