New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ODF install tour #559
Adds ODF install tour #559
Conversation
@openshift/quickstart-ux-content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a few changes and have some questions. Thanks for pinging me for a review!
I'd assume this should be called odf-install-tour ?
If we want to rename the resource, I believe we can now add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I dont think that we can just rename the CVO managed resources. As @spadgett mentioned we should rather add the release.openshift.io/delete: "true"
annotation to the old manifest so it's removed and create the new ODF install tour.
Signed-off-by: Vineet Badrinath <vbadrina@redhat.com>
c9cb711
to
389ab54
Compare
/test e2e-aws-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, vbnrh, yuvalgalanti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For 4.9 release, OCS operator will be replaced with the ODF at a higher level. Hence we would want to make sure that new install quickstart accurately represent the workflows for ODF operator.
This commit adds quickstart for installing the ODF operator and setting up the storage cluster.
Signed-off-by: Vineet Badrinath vbadrina@redhat.com