Bug 1975379: Use hard requirement for anti-affinity rules on both console's deployments

[jhadvig]

Use requiredDuringSchedulingIgnoredDuringExecution for anti-affinity rules on both console's deployments.
The label selectors for console deployment will be:
"app": "console", "component": "ui"
The label selectors for downloads deployment will be:
"app": "console", "component": "downloads"

/assign @spadgett

[openshift-ci]

@jhadvig: This pull request references Bugzilla bug 1975379, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1975379: Use hard requirement for anti-affinity rules on both console's deployments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/bugzilla refresh

[openshift-ci]

@jhadvig: This pull request references Bugzilla bug 1975379, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

/test ci/prow/e2e-aws-single-node

[openshift-ci]

@spadgett: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

• /test e2e-agnostic-upgrade
• /test e2e-aws-console
• /test e2e-aws-operator
• /test e2e-aws-single-node
• /test e2e-gcp
• /test images
• /test unit
• /test verify

Use /test all to run the following jobs:

• pull-ci-openshift-console-operator-master-e2e-agnostic-upgrade
• pull-ci-openshift-console-operator-master-e2e-aws-console
• pull-ci-openshift-console-operator-master-e2e-aws-operator
• pull-ci-openshift-console-operator-master-e2e-gcp
• pull-ci-openshift-console-operator-master-images
• pull-ci-openshift-console-operator-master-unit
• pull-ci-openshift-console-operator-master-verify

In response to this:

/test ci/prow/e2e-aws-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

/test e2e-aws-single-node

[spadgett]

/lgtm

[spadgett]

Hm, looks like this prevents console rollout:

status:
  conditions:
  - lastProbeTime: null
    lastTransitionTime: "2021-06-24T16:59:02Z"
    message: '0/6 nodes are available: 3 node(s) didn''t match Pod''s node affinity/selector,
      3 node(s) didn''t match pod affinity/anti-affinity rules, 3 node(s) didn''t
      match pod anti-affinity rules.'
    reason: Unschedulable
    status: "False"
    type: PodScheduled
  phase: Pending

/lgtm cancel

[spadgett]

I have a feeling the problem is with rolling deployments since we'll have more than the normal number of replicas. If there are ever more than 3, they'll fail to schedule. We probably need to look at max surge and max unavailable if we want to make this a hard requirement.

[jhadvig]

@spadgett I've added additional commit that update podAntiAffinity rules and explicitly specifies deployment strategy and its maxSurge and maxUnavailability 🤞

[jhadvig]

/retest

[spadgett]

/retest

[spadgett]

/retest

[openshift-ci]

@jhadvig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-single-node	cc5938b	link	/test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[spadgett]

/retest

[spadgett]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jhadvig,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jhadvig: All pull requests linked via external trackers have merged:

• openshift/console-operator#560

Bugzilla bug 1975379 has been moved to the MODIFIED state.

In response to this:

Bug 1975379: Use hard requirement for anti-affinity rules on both console's deployments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.