New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2000440: OCS Quick Start should not be shown unless you have proper privileges #578
Conversation
Replying to @spadgett comment #577 (comment) Why do they need the ability to create a namespace? They should also be able to install the operator into an existing namespace. Likely the admin would have this permission anyways though. |
@christianvogt The quick start as written has you creating and installing into namespace |
(That is if you follow the steps and take the defaults in the form it will create the namespace.) |
I should have read the quick start before I commented :) Indeed if that's how the quick starts are written then this makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, yozaam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@yozaam: This pull request references Bugzilla bug 2000440, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@yozaam: This pull request references Bugzilla bug 2000440, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@yozaam: All pull requests linked via external trackers have merged: Bugzilla bug 2000440 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: https://issues.redhat.com/browse/ODC-6241 ( relates to https://issues.redhat.com/browse/ODC-6161 )
Added the described accessReviewResources inside OCS quickstart -spec
since this quick start should only be available if you can install operators
doubt
I am seeing the operator install option in
KUBEADMIN
loginbut not seeing the quickstart, is this expected from the given
accessReviewResources: