Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2000440: OCS Quick Start should not be shown unless you have proper privileges #578

Merged
merged 1 commit into from Sep 2, 2021

Conversation

yozaam
Copy link
Contributor

@yozaam yozaam commented Aug 30, 2021

Fixes: https://issues.redhat.com/browse/ODC-6241 ( relates to https://issues.redhat.com/browse/ODC-6161 )

Added the described accessReviewResources inside OCS quickstart -spec

since this quick start should only be available if you can install operators

doubt

I am seeing the operator install option in KUBEADMIN login
image

but not seeing the quickstart, is this expected from the given accessReviewResources:
image

@christianvogt
Copy link

Replying to @spadgett comment #577 (comment)

Why do they need the ability to create a namespace? They should also be able to install the operator into an existing namespace. Likely the admin would have this permission anyways though.

@spadgett
Copy link
Member

@christianvogt The quick start as written has you creating and installing into namespace openshift-storage. (I believe this is also required by the operator.)

@spadgett
Copy link
Member

spadgett commented Aug 30, 2021

(That is if you follow the steps and take the defaults in the form it will create the namespace.)

@christianvogt
Copy link

I should have read the quick start before I commented :) Indeed if that's how the quick starts are written then this makes sense.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, yozaam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@yozaam yozaam changed the title OCS Quick Start should not be shown unless you have proper privileges Bug 2000440: OCS Quick Start should not be shown unless you have proper privileges Sep 2, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

@yozaam: This pull request references Bugzilla bug 2000440, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2000440: OCS Quick Start should not be shown unless you have proper privileges

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 2, 2021
@yozaam
Copy link
Contributor Author

yozaam commented Sep 2, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

@yozaam: This pull request references Bugzilla bug 2000440, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit aa5adf5 into openshift:master Sep 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

@yozaam: All pull requests linked via external trackers have merged:

Bugzilla bug 2000440 has been moved to the MODIFIED state.

In response to this:

Bug 2000440: OCS Quick Start should not be shown unless you have proper privileges

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants