Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2055494: Distinguish between route conditions #662

Merged
merged 1 commit into from Jul 18, 2022
Merged

Bug 2055494: Distinguish between route conditions #662

merged 1 commit into from Jul 18, 2022

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Jul 8, 2022 •
edited

Since the RouteController is used for console and downloads routes so we need to distinguish between there two routes and their conditions.

/assign @stlaz

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

@jhadvig: This pull request references Bugzilla bug 2055494, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2031839 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2031839 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 2055494: Distinguish between route conditions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from yapei, bparees and spadgett July 8, 2022 10:23
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

@jhadvig: This pull request references Bugzilla bug 2055494, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2031839 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2031839 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 2055494: Distinguish between route conditions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

@jhadvig: This pull request references Bugzilla bug 2055494, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2031839 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2031839 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 2055494: Distinguish between route conditions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stlaz
Copy link
Member

stlaz commented Jul 8, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig
Copy link
Member Author

jhadvig commented Jul 8, 2022

/test e2e-aws-console

@jhadvig
Copy link
Member Author

jhadvig commented Jul 9, 2022

/retest

@jhadvig jhadvig added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Jul 11, 2022
@jhadvig
Copy link
Member Author

jhadvig commented Jul 11, 2022

Adding label manually since this fix is only needed for 4.9 release.

@jhadvig
Copy link
Member Author

jhadvig commented Jul 11, 2022

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD dbe81b4 and 8 for PR HEAD 8e4d5e9 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD dbe81b4 and 7 for PR HEAD 8e4d5e9 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dbe81b4 and 6 for PR HEAD 8e4d5e9 in total

@jhadvig
Copy link
Member Author

jhadvig commented Jul 14, 2022

/test e2e-aws-console

1 similar comment
@jhadvig
Copy link
Member Author

jhadvig commented Jul 15, 2022

/test e2e-aws-console

@jhadvig
Copy link
Member Author

jhadvig commented Jul 18, 2022 

  1) Create namespace from install operators
       creates namespace from operator install page:
     CypressError: Timed out retrying after 30050ms: `cy.click()` failed because this element is `disabled`:
`<button aria-haspopup="true" aria-expanded="false" class="pf-c-dropdown__toggle" data-test-id="dropdown-button" type="button" id="dropdown-selectbox" data-test="dropdown-selectbox" disabled="">...</button>`

/test e2e-aws-console

@jhadvig
Copy link
Member Author

jhadvig commented Jul 18, 2022

/override ci/prow/e2e-aws-console

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2022

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-aws-console

In response to this:

/override ci/prow/e2e-aws-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2022

@jhadvig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-console 8e4d5e9 link true /test e2e-aws-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit b3f1401 into openshift:release-4.9 Jul 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2022

@jhadvig: All pull requests linked via external trackers have merged:

Bugzilla bug 2055494 has been moved to the MODIFIED state.

In response to this:

Bug 2055494: Distinguish between route conditions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-operator-container-v4.9.0-202311250023.p0.gb3f1401.assembly.stream for distgit openshift-enterprise-console-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yapei yapei Awaiting requested review from yapei

@bparees bparees Awaiting requested review from bparees

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@stlaz stlaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhadvig @stlaz @openshift-ci-robot @openshift-bot