Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-2219: Empty string should be valid for i18n loadType #689

Merged
merged 1 commit into from Oct 28, 2022
Merged

OCPBUGS-2219: Empty string should be valid for i18n loadType #689

merged 1 commit into from Oct 28, 2022

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Oct 18, 2022

No description provided.

@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-2219, which is invalid:

  • expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 18, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2022
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2022
@jhadvig
Copy link
Member Author

jhadvig commented Oct 19, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 19, 2022
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-2219, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 19, 2022
@openshift-ci openshift-ci bot requested a review from yapei October 19, 2022 12:19
This was referenced Oct 19, 2022
Merged
Merged
@jhadvig jhadvig changed the title [WIP] OCPBUGS-2219: Empty string should be valid for i18n loadType OCPBUGS-2219: Empty string should be valid for i18n loadType Oct 19, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2022
TheRealJon
TheRealJon reviewed Oct 19, 2022
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one question.

go.mod Outdated
@@ -109,3 +109,5 @@ require (
sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect
sigs.k8s.io/yaml v1.2.0 // indirect
)

replace github.com/openshift/api => github.com/jhadvig/api v0.0.0-20221018122159-ba7b5828983d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be merged?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope ... forgot to remove :(

TheRealJon
TheRealJon approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2022
@jhadvig
Copy link
Member Author

jhadvig commented Oct 20, 2022

/retest

@jhadvig
Copy link
Member Author

jhadvig commented Oct 21, 2022

/test e2e-agnostic-upgrade

3 similar comments
@jhadvig
Copy link
Member Author

jhadvig commented Oct 26, 2022

/test e2e-agnostic-upgrade

@jhadvig
Copy link
Member Author

jhadvig commented Oct 26, 2022

/test e2e-agnostic-upgrade

@jhadvig
Copy link
Member Author

jhadvig commented Oct 27, 2022

/test e2e-agnostic-upgrade

@jhadvig
Copy link
Member Author

jhadvig commented Oct 27, 2022

/retest

@jhadvig
Copy link
Member Author

jhadvig commented Oct 27, 2022

/test e2e-aws-operator

1 similar comment
@jhadvig
Copy link
Member Author

jhadvig commented Oct 28, 2022

/test e2e-aws-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2022

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f6fc4c8 into openshift:master Oct 28, 2022
@openshift-ci-robot
Copy link
Contributor

@jhadvig: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-2219 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealJon TheRealJon TheRealJon approved these changes

@spadgett spadgett Awaiting requested review from spadgett

@yapei yapei Awaiting requested review from yapei

Assignees

@TheRealJon TheRealJon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhadvig @openshift-ci-robot @TheRealJon @openshift-merge-robot