Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.10] OCPBUGS-11342: Deleting downloads deployment should not fail if already deleted #744

Merged
merged 1 commit into from Aug 25, 2023
Merged

[release-4.10] OCPBUGS-11342: Deleting downloads deployment should not fail if already deleted #744

merged 1 commit into from Aug 25, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #715

/assign jhadvig

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 4, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-5518 has been cloned as Jira Issue OCPBUGS-11342. Will retitle bug to link to clone.
/retitle [release-4.10] OCPBUGS-11342: Deleting downloads deployment should not fail if already deleted

In response to this:

This is an automated cherry-pick of #715

/assign jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jhadvig jhadvig changed the title [release-4.10] OCPBUGS-5518: Deleting downloads deployment should not fail if already deleted [release-4.10] OCPBUGS-11342: Deleting downloads deployment should not fail if already deleted Apr 4, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 4, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-11342, which is invalid:

  • expected dependent Bugzilla Bug 2089950 to target a version in 4.11.0, 4.11.z, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #715

/assign jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.10] OCPBUGS-11342: Deleting downloads deployment should not fail if already deleted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jhadvig
Copy link
Member

jhadvig commented Apr 4, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-11342, which is invalid:

  • expected dependent Bugzilla Bug 2089950 to target a version in 4.11.0, 4.11.z, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jhadvig and spadgett April 4, 2023 09:20
@jhadvig
Copy link
Member

jhadvig commented Apr 4, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 4, 2023
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-11342, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.10.z) matches configured target version for branch (4.10.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-5518 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-5518 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei April 4, 2023 09:21
@jhadvig
Copy link
Member

jhadvig commented Apr 4, 2023

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 4, 2023
@jhadvig jhadvig added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@jhadvig
Copy link
Member

jhadvig commented Apr 4, 2023

/retest

jhadvig
jhadvig reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig
Copy link
Member

jhadvig commented Apr 11, 2023

/retest

@jhadvig
Copy link
Member

jhadvig commented Apr 12, 2023

flake
/retest

@yapei
Copy link
Contributor

yapei commented Apr 13, 2023

  1. setup 4.10 SNO cluster with fix PR included
  2. set managementState to Removed
  3. Trigger an upgrade to 4.11, upgrade was successful
    /label qe-approved
    /label cherry-pick-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Apr 13, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6673dd7 and 2 for PR HEAD e734af5 in total

@jhadvig
Copy link
Member

jhadvig commented Apr 17, 2023

/retest

3 similar comments
@jhadvig
Copy link
Member

jhadvig commented Apr 20, 2023

/retest

@jhadvig
Copy link
Member

jhadvig commented Apr 24, 2023

/retest

@jhadvig
Copy link
Member

jhadvig commented May 4, 2023

/retest

@yapei
Copy link
Contributor

yapei commented May 9, 2023

test flake

 === RUN   TestEditUnmanagedConfigMap
    unmanaged_test.go:12: waiting for setup to reach settled state...
    unmanaged_test.go:13: changing console operator state to 'Unmanaged'...
    util.go:28: patching Data on the console ConfigMap
    util.go:35: polling for patched Data on the console ConfigMap
    unmanaged_test.go:41: error: timed out waiting for the condition
    unmanaged_test.go:18: waiting for cleanup to reach settled state...
    console-operator.go:370: waited 10 seconds to reach settled state...
--- FAIL: TestEditUnmanagedConfigMap (35.82s)

/test e2e-aws-operator

@jhadvig
Copy link
Member

jhadvig commented May 10, 2023

/retest

1 similar comment
@jhadvig
Copy link
Member

jhadvig commented May 15, 2023

/retest

@jhadvig
Copy link
Member

jhadvig commented May 16, 2023

/test e2e-aws-operator

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6673dd7 and 2 for PR HEAD e734af5 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6673dd7 and 2 for PR HEAD e734af5 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6128426 and 1 for PR HEAD e734af5 in total

@jhadvig
Copy link
Member

jhadvig commented Jul 3, 2023

/retest

2 similar comments
@jhadvig
Copy link
Member

jhadvig commented Jul 24, 2023

/retest

@jhadvig
Copy link
Member

jhadvig commented Aug 25, 2023

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6128426 and 2 for PR HEAD e734af5 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7ec7b2f into openshift:release-4.10 Aug 25, 2023
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-11342: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11342 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #715

/assign jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.10.0-0.nightly-2023-08-26-150604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig left review comments

@spadgett spadgett Awaiting requested review from spadgett

@yapei yapei Awaiting requested review from yapei

Assignees

@jhadvig jhadvig

@yanpzhan yanpzhan

@yapei yapei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @jhadvig @yapei @openshift-merge-robot @yanpzhan