OCPBUGS-24203: ConsolePlugin metrics must no longer be grouped by the vendor #819
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@jerolimov: This pull request references Jira Issue OCPBUGS-24203, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@jerolimov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@jerolimov: Jira Issue OCPBUGS-24203: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-24203 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-console-operator-container-v4.15.0-202311301849.p0.g8688bb1.assembly.stream for distgit openshift-enterprise-console-operator. |
|
/cherry-pick release-4.14 |
|
@jerolimov: new pull request created: #820 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Fix included in accepted release 4.15.0-0.nightly-2023-12-02-123536 |
|
Thanks @jhadvig for merging this faster then expected 👍 Double-checked this now on a nightly build:
|
The monitoring team is fine that we save all installed, known RH plugin names in our metrics/promtheus, instead of grouping them by "redhat", "demo" and "others".
openshift/console#13383 removed this mapping to a vendor and replaced it with a mapping to simplified plugin names.
This PR is required so that the metrics from the console are exported correctly to the cluster monitoring.