Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-21029: Bump library-go and golang.org/x/net #850

Merged
merged 1 commit into from Feb 20, 2024
Merged

[release-4.14] OCPBUGS-21029: Bump library-go and golang.org/x/net #850

merged 1 commit into from Feb 20, 2024

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Jan 26, 2024

/assign @stlaz

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 26, 2024
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-21029, which is invalid:

  • expected Jira Issue OCPBUGS-21029 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/assign @stlaz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@jhadvig
Copy link
Member Author

jhadvig commented Jan 26, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 26, 2024
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-21029, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-21972 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-21972 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei January 26, 2024 10:49
stlaz
stlaz suggested changes Jan 26, 2024
View reviewed changes
go.mod Outdated
k8s.io/apimachinery v0.27.3
k8s.io/client-go v0.27.3
k8s.io/component-base v0.27.3
k8s.io/api v0.28.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ocp 4.14 is kube 1.27 (https://access.redhat.com/solutions/4870701)

@stlaz
Copy link
Member

stlaz commented Jan 26, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
@jhadvig
Copy link
Member Author

jhadvig commented Jan 29, 2024

/retest

3 similar comments
@jhadvig
Copy link
Member Author

jhadvig commented Feb 1, 2024

/retest

@jcaianirh
Copy link
Member

/retest

@jhadvig
Copy link
Member Author

jhadvig commented Feb 6, 2024

/retest

@jhadvig
Copy link
Member Author

jhadvig commented Feb 8, 2024

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 8, 2024
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 9, 2024
Merged
@jhadvig jhadvig force-pushed the OCPBUGS-21029 branch 2 times, most recently from d8f8715 to e761ed9 Compare February 9, 2024 16:05
@stlaz
Copy link
Member

stlaz commented Feb 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig
Copy link
Member Author

jhadvig commented Feb 9, 2024

/retest

@jhadvig
Copy link
Member Author

jhadvig commented Feb 9, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2024
@TheRealJon
Copy link
Member

/label backport-risk-assessed

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

@TheRealJon: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jhadvig
Copy link
Member Author

jhadvig commented Feb 12, 2024

/label backport-risk-assessed
/retest

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jhadvig jhadvig mentioned this pull request Feb 14, 2024
Merged
@jerolimov
Copy link
Member

/retitle [release-4.14] OCPBUGS-21029: Bump library-go and golang.org/x/net

@openshift-ci openshift-ci bot changed the title OCPBUGS-21029: Bump library-go and golang.org/x/net [release-4.14] OCPBUGS-21029: Bump library-go and golang.org/x/net Feb 19, 2024
@XiyunZhao
Copy link

No issue was found on the regression test on the OCP4.14 cluster created by the bot
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 20, 2024
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-21029, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-21972 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-21972 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/assign @stlaz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yanpzhan
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 855f3fc into openshift:release-4.14 Feb 20, 2024
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@jhadvig: Jira Issue OCPBUGS-21029: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-21029 has been moved to the MODIFIED state.

In response to this:

/assign @stlaz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-operator-container-v4.14.0-202402200939.p0.g855f3fc.assembly.stream.el8 for distgit openshift-enterprise-console-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-02-20-213853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlaz stlaz stlaz requested changes

@spadgett spadgett Awaiting requested review from spadgett

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@yapei yapei Awaiting requested review from yapei

Assignees

@stlaz stlaz

@yanpzhan yanpzhan

@yapei yapei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet