OCPBUGS-29479: Add startupProbe to console container. #869
Conversation
Use startup probe on console container to account for possible long start times from auth initialization. This will help to avoid unnecessary restarts of the console pod.
openshift-ci-robot
added
the
jira/valid-reference
|
@TheRealJon: This pull request references Jira Issue OCPBUGS-29479, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
openshift-ci
bot
added
the
approved
|
cc @sdodson |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@TheRealJon: This pull request references Jira Issue OCPBUGS-29479, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
| periodSeconds: 10 | ||
| successThreshold: 1 | ||
| failureThreshold: 3 | ||
| startupProbe: |
There was a problem hiding this comment.
I like the idea of this change. This makes the startup wait 5 minutes instead of 2.5 minutes. That seems ok to me if you find it reasonable, but I want to be sure the difference is obvious.
There was a problem hiding this comment.
Yes, this was intentional. In the worst case, the console will take 5 minutes to start. See openshift/console#13610
| @@ -70,11 +70,15 @@ spec: | |||
| path: /health | |||
| port: 8443 | |||
| scheme: HTTPS | |||
| initialDelaySeconds: 150 | |||
There was a problem hiding this comment.
Glad to see this changed since the startup probe means that as soon as the server is healthy it will properly handled.
|
/lgtm cancel |
…and order probe definitions logically.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
@TheRealJon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@jhadvig: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
@TheRealJon: Jira Issue OCPBUGS-29479: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-29479 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-console-operator-container-v4.16.0-202402192309.p0.g057fe07.assembly.stream.el9 for distgit openshift-enterprise-console-operator. |
|
Fix included in accepted release 4.16.0-0.nightly-2024-03-30-033956 |
Use startup probe on console container to account for possible long start times from auth initialization. This will help to avoid unnecessary restarts of the console pod.