OCPBUGS-31020,CONSOLE-3944: Disable segment analytics when cluster telemetry is disabled

[TheRealJon]

Watch the cluster monitoring config for the telemeter client. If it's disabled, set a new console config property telemetry.TELEMETER_CLIENT_DISABLED to true so that all telemetry requests from the frontend can be halted.

[openshift-ci-robot]

@TheRealJon: This pull request references CONSOLE-3944 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Watch the cluster monitoring config for the telemeter client. If it's disabled, set a new console config property telemetry.telemeterClientDisabled to true so that all telemetry requests from the frontend can be halted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[TheRealJon]

QE Approver
/assign @yapei

Docs Approver:
/assign @opayne1

PX Approver:
/assign @RickJWagner

[jerolimov]

/cc @jerolimov @jhadvig
/assign @jerolimov @jhadvig

[TheRealJon]

@yapei I've updated this PR to address https://issues.redhat.com/browse/OCPBUGS-31020

@jerolimov Could you review this and make sure this logic is sound?

If no cluster monitoring config
  telemeter client enabled
Else if (no ClusterID || no Token || Enabled == false) in cluster monitoring config
  telemeter client disabled
Else
  telemeter client enabled

[openshift-ci-robot]

@TheRealJon: This pull request references Jira Issue OCPBUGS-31020, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references CONSOLE-3944 which is a valid jira issue.

In response to this:

Watch the cluster monitoring config for the telemeter client. If it's disabled, set a new console config property telemetry.telemeterClientDisabled to true so that all telemetry requests from the frontend can be halted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[TheRealJon]

/jira refresh

[openshift-ci-robot]

@TheRealJon: This pull request references Jira Issue OCPBUGS-31020, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

This pull request references CONSOLE-3944 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[TheRealJon]

/retest

[RickJWagner]

/label px-approved

[jan--f]

@yapei I've updated this PR to address https://issues.redhat.com/browse/OCPBUGS-31020

@jerolimov Could you review this and make sure this logic is sound?

If no cluster monitoring config
  telemeter client enabled
Else if (no ClusterID || no Token || Enabled == false) in cluster monitoring config
  telemeter client disabled
Else
  telemeter client enabled

Yep I think that is correct.

[jhadvig]

Thanks for PR @TheRealJon. Adding a few comments.
Also based on conversation with @simonpasquier it seems that the clusterID and token are never stored in the configmap in practice but populated respectively from the ClusterVersion version object and openshift-config/pull-secret Secret.
https://github.com/openshift/cluster-monitoring-operator/blob/800bedc61f101cd4450f45535f7bfafb72112c4f/pkg/manifests/config.go#L354-L367
https://github.com/openshift/cluster-monitoring-operator/blob/800bedc61f101cd4450f45535f7bfafb72112c4f/pkg/manifests/config.go#L368-L396

[jhadvig]

@TheRealJon looks you forgot to update TCs.

[openshift-ci-robot]

@TheRealJon: This pull request references Jira Issue OCPBUGS-31020, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

This pull request references CONSOLE-3944 which is a valid jira issue.

In response to this:

Watch the cluster monitoring config for the telemeter client. If it's disabled, set a new console config property telemetry.TELEMETER_CLIENT_DISABLED to true so that all telemetry requests from the frontend can be halted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[TheRealJon]

/retest

[jerolimov]

/retest

[openshift-ci]

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jhadvig]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [TheRealJon,jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@TheRealJon: Jira Issue OCPBUGS-31020: All pull requests linked via external trackers have merged:

• openshift/console-operator#877

Jira Issue OCPBUGS-31020 has been moved to the MODIFIED state.

In response to this:

Watch the cluster monitoring config for the telemeter client. If it's disabled, set a new console config property telemetry.TELEMETER_CLIENT_DISABLED to true so that all telemetry requests from the frontend can be halted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-operator-container-v4.16.0-202404051041.p0.g7415be3.assembly.stream.el9 for distgit openshift-enterprise-console-operator.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-04-05-200353