Merge pull request #8935 from spadgett/4.7-fix-global-config-hotloop

Bug 1960686: Fix hot loop in global config page
openshift · Jun 7, 2021 · 0a2a645 · 0a2a645
2 parents dcf1720 + 0509c50
commit 0a2a645
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/frontend/public/components/cluster-settings/global-config.tsx b/frontend/public/components/cluster-settings/global-config.tsx
@@ -57,12 +57,11 @@ const GlobalConfigPage_: React.FC<GlobalConfigPageProps & GlobalConfigPageExtens
   const [textFilter, setTextFilter] = React.useState('');
   const { t } = useTranslation();
 
-  const oauthMenuItems = _.map(addIDPItems, (label: string, id: string) => ({
-    label: t('public~{{label}}', { label }),
-    href: `/settings/idp/${id}`,
-  }));
-
   React.useEffect(() => {
+    const oauthMenuItems = _.map(addIDPItems, (label: string, id: string) => ({
+      label: t('public~{{label}}', { label }),
+      href: `/settings/idp/${id}`,
+    }));
     const editYAMLMenuItem = (name: string, resourceLink: string) => ({
       label: t('global-config~Edit {{name}} resource', { name }),
       href: `${resourceLink}/yaml`,
@@ -134,7 +133,7 @@ const GlobalConfigPage_: React.FC<GlobalConfigPageProps & GlobalConfigPageExtens
       }
     });
     return () => (isSubscribed = false);
-  }, [configResources, errors, globalConfigs, oauthMenuItems, t]);
+  }, [configResources, globalConfigs, t]);
   const visibleItems = items.filter(({ label, description = '' }) => {
     return (
       fuzzyCaseInsensitive(textFilter, label) ||