fix(dev-catalog): reject the internal objects when creating objects o…

…ut from CSV

frontend/packages/operator-lifecycle-manager/src/dev-catalog.ts

@@ -4,6 +4,22 @@ import { ClusterServiceVersionKind } from './types';
 import { referenceForProvidedAPI, providedAPIsFor } from './components';
 import * as operatorLogo from './operator.svg';
 
+const isInternal = (crd: { name: string }): boolean => {
+  const internalOpListString = _.get(
+    crd,
+    ['csv', 'metadata', 'annotations', 'operators.operatorframework.io/internal-objects'],
+    '[]',
+  );
+  try {
+    const internalOpList = internalOpListString.slice(1, -1).split(','); // JSON.parse fails or returns improper structure
+    if (!internalOpList.length || internalOpList.length === 0) return false;
+    return !!internalOpList.find((op) => op.slice(1, -1) === crd.name);
+  } catch {
+    /* eslint-disable-next-line no-console */
+    console.error('Failed to parse CSV annotation: Invalid JSON structure');
+    return false;
+  }
+};
 export const normalizeClusterServiceVersions = (
   clusterServiceVersions: ClusterServiceVersionKind[],
 ): K8sResourceKind[] => {
@@ -24,6 +40,8 @@ export const normalizeClusterServiceVersions = (
           : all.concat([cur]),
       [],
     )
+    // remove internal CRDs
+    .filter((crd) => !isInternal(crd))
     .map((desc) => ({
       // NOTE: Faking a real k8s object to avoid fetching all CRDs
       obj: {

frontend/public/components/catalog/catalog-page.tsx

@@ -114,15 +114,7 @@ export class CatalogListPage extends React.Component<CatalogListPageProps, Catal
       ...projectTemplateItems,
     ];
 
-    //blacklisting all CRDs with annotation 'operators.operatorframework.io/internal-object' set to true
-    const filteredItems = _.reject(items, [
-      'obj',
-      'metadata',
-      'annotations',
-      'operators.operatorframework.io/internal-object',
-    ]);
-
-    return _.sortBy(filteredItems, 'tileName');
+    return _.sortBy(items, 'tileName');
   }
 
   normalizeClusterServiceClasses(serviceClasses) {