Merge pull request #13177 from rhamilto/OCPBUGS-19394

OCPBUGS-19394: document kebab menu cell props
openshift · Sep 22, 2023 · 114258d · 114258d
2 parents bae2dea + 942578e
commit 114258d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/frontend/packages/console-dynamic-plugin-sdk/docs/api.md b/frontend/packages/console-dynamic-plugin-sdk/docs/api.md
@@ -563,6 +563,10 @@ const PodRow: React.FC<RowProps<K8sResourceCommon>> = ({ obj, activeColumnIDs })
       <TableData id={columns[1].id} activeColumnIDs={activeColumnIDs}>
         <ResourceLink kind="Namespace" name={obj.metadata.namespace} />
       </TableData>
+      // Important:  the kebab menu cell should include the id and className prop values below
+      <TableData id='' className='pf-c-table__action' activeColumnIDs={activeColumnIDs}>
+        <MockKebabMenu obj={obj} />
+     </TableData>
     </>
   );
 };

diff --git a/frontend/packages/console-dynamic-plugin-sdk/src/api/dynamic-core-api.ts b/frontend/packages/console-dynamic-plugin-sdk/src/api/dynamic-core-api.ts
@@ -128,6 +128,10 @@ export const VirtualizedTable: VirtualizedTableFC = require('@console/internal/c
  *       <TableData id={columns[1].id} activeColumnIDs={activeColumnIDs}>
  *         <ResourceLink kind="Namespace" name={obj.metadata.namespace} />
  *       </TableData>
+ *       // Important:  the kebab menu cell should include the id and className prop values below
+ *       <TableData id='' className='pf-c-table__action' activeColumnIDs={activeColumnIDs}>
+ *         <MockKebabMenu obj={obj} />
+ *      </TableData>
  *     </>
  *   );
  * };