test

openshift · Sep 10, 2020 · 141e118 · 141e118
1 parent f74a4b9
commit 141e118
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/frontend/packages/integration-tests-cypress/tests/app/auth-multiuser-login.spec.ts b/frontend/packages/integration-tests-cypress/tests/app/auth-multiuser-login.spec.ts
@@ -50,8 +50,8 @@ describe('Auth test', () => {
     cy.visit('');
     cy.url().should('include', Cypress.env('appHost'));
     masthead.username.shouldHaveText(KUBEADMIN_IDP);
-    cy.byTestID('global-notification-text').contains(
-      // cy.get('.co-global-notifications').contains(
+    // cy.get('.co-global-notifications').contains(
+    cy.byTestID('global-notifications').contains(
       'You are logged in as a temporary administrative user. Update the cluster OAuth configuration to allow others to log in.',
     );
 

diff --git a/frontend/public/components/console-notifier.tsx b/frontend/public/components/console-notifier.tsx
@@ -27,7 +27,7 @@ const ConsoleNotifier_: React.FC<ConsoleNotifierProps> = ({ obj, location }) =>
             data-test={`${notification.metadata.name}-${notification.spec.location}`}
           >
             <div className="co-global-notification__content">
-              <p className="co-global-notification__text" data-test="global-notification-text">
+              <p className="co-global-notification__text">
                 {notification.spec.text}{' '}
                 {_.get(notification.spec, ['link', 'href']) && (
                   <a

diff --git a/frontend/public/components/global-notifications.jsx b/frontend/public/components/global-notifications.jsx
@@ -4,7 +4,7 @@ import { ImpersonateNotifier } from './impersonate-notifier';
 import { KubeAdminNotifier } from './kube-admin-notifier';
 
 export const GlobalNotifications = () => (
-  <div className="co-global-notifications">
+  <div className="co-global-notifications" data-test="global-notifications">
     <KubeAdminNotifier />
     <ImpersonateNotifier />
   </div>

diff --git a/test-prow-e2e.sh b/test-prow-e2e.sh
@@ -38,6 +38,6 @@ CHROME_VERSION=$(google-chrome --version) ./test-gui.sh "${1:-e2e}"
 if [ $# -eq 0 ] || [ "$1" == "release" ]; then
   ./test-cypress.sh
 fi
-if ["$1" == "login" ]; then
+if [ $# -eq 1 ] && ["$1" == "login" ]; then
   ./test-cypress.sh 'tests/app/auth-multiuser-login.spec.ts'
 fi