page-fail-return-secret-list

openshift · Feb 5, 2024 · 2c897d8 · 2c897d8
1 parent 74c31e3
commit 2c897d8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/frontend/packages/dev-console/src/components/import/CreateSecretModal.tsx b/frontend/packages/dev-console/src/components/import/CreateSecretModal.tsx
@@ -24,8 +24,8 @@ const CreateSecretModal: React.FC<Props> = ({ close, namespace, save, secretType
 
   return (
     <SecretFormWrapper
-      onCancel={close}
       onSave={handleSave}
+      onCancel={close}
       fixed={{ metadata: { namespace } }}
       secretTypeAbstraction={secretType}
       isCreate

diff --git a/frontend/public/components/secrets/create-secret.tsx b/frontend/public/components/secrets/create-secret.tsx
@@ -138,6 +138,7 @@ export const SecretFormWrapper: React.FC<BaseEditSecretProps_> = (props) => {
   const { isCreate, modal, onCancel } = props;
   const { t } = useTranslation();
   const navigate = useNavigate();
+  const params = useParams();
 
   const existingSecret = _.pick(props.obj, ['metadata', 'type']);
   const defaultSecretType = toDefaultSecretType(props.secretTypeAbstraction);
@@ -163,7 +164,7 @@ export const SecretFormWrapper: React.FC<BaseEditSecretProps_> = (props) => {
   const [base64StringData, setBase64StringData] = React.useState({});
   const [disableForm, setDisableForm] = React.useState(false);
 
-  const defaultCancel = () => navigate(-1);
+  const cancel = () => navigate(`/k8s/ns/${params.ns}/core~v1~Secret`);
 
   const onDataChanged = (secretsData) => {
     setStringData({ ...secretsData?.stringData });
@@ -272,7 +273,7 @@ export const SecretFormWrapper: React.FC<BaseEditSecretProps_> = (props) => {
         errorMessage={error || ''}
         inProgress={inProgress}
         submitText={t('public~Create')}
-        cancel={props.onCancel || defaultCancel}
+        cancel={onCancel || cancel}
       />
     </form>
   ) : (
@@ -295,12 +296,7 @@ export const SecretFormWrapper: React.FC<BaseEditSecretProps_> = (props) => {
               >
                 {props.saveButtonText || t('public~Create')}
               </Button>
-              <Button
-                type="button"
-                variant="secondary"
-                id="cancel"
-                onClick={onCancel || defaultCancel}
-              >
+              <Button type="button" variant="secondary" id="cancel" onClick={onCancel || cancel}>
                 {t('public~Cancel')}
               </Button>
             </ActionGroup>