hide scale buttons in donut for Pods

openshift · Dec 7, 2020 · 37ad641 · 37ad641
1 parent 7b07e5c
commit 37ad641
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/frontend/packages/console-shared/src/utils/__tests__/pod-ring-utils.spec.ts b/frontend/packages/console-shared/src/utils/__tests__/pod-ring-utils.spec.ts
@@ -1,7 +1,7 @@
 import * as _ from 'lodash';
 import { TFunction } from 'i18next';
 import { K8sResourceKind } from '@console/internal/module/k8s';
-import { DeploymentConfigModel } from '@console/internal/models';
+import { DeploymentConfigModel, PodModel } from '@console/internal/models';
 import { RevisionModel } from '@console/knative-plugin';
 import * as utils from '../pod-utils';
 import { usePodScalingAccessStatus, podRingLabel, getFailedPods } from '../pod-ring-utils';
@@ -199,6 +199,14 @@ describe('usePodScalingAccessStatus', () => {
     });
   });
 
+  it('should return false for pods', (done) => {
+    obj.kind = 'Pod';
+    testHook(() => {
+      expect(usePodScalingAccessStatus(obj, PodModel, [], true)).toBe(false);
+      done();
+    });
+  });
+
   it('should return false when api call returns false for a resource', (done) => {
     obj.kind = 'DeploymentConfig';
     testHook(() => {

diff --git a/frontend/packages/console-shared/src/utils/pod-ring-utils.ts b/frontend/packages/console-shared/src/utils/pod-ring-utils.ts
@@ -252,6 +252,7 @@ export const usePodScalingAccessStatus = (
   }, [pods, obj, resourceKind, impersonate, setEditable]);
 
   const isKnativeRevision = obj.kind === 'Revision';
-  const isScalingAllowed = !isKnativeRevision && editable && enableScaling;
+  const isPod = obj.kind === 'Pod';
+  const isScalingAllowed = !isKnativeRevision && !isPod && editable && enableScaling;
   return isScalingAllowed;
 };