Skip to content

Commit

Permalink
Update labels section example placeholder
Browse files Browse the repository at this point in the history
  • Loading branch information
divyanshiGupta committed Jun 16, 2021
1 parent fe0f165 commit 3c22e1b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions frontend/packages/dev-console/locales/en/devconsole.json
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@
"Launch the first build when the build configuration is created": "Launch the first build when the build configuration is created",
"Environment variables (build and runtime)": "Environment variables (build and runtime)",
"Each label is applied to each created resource.": "Each label is applied to each created resource.",
"appType=frontend": "appType=frontend",
"Resource limit": "Resource limit",
"Resource limits control how much CPU and memory a container will consume on a node.": "Resource limits control how much CPU and memory a container will consume on a node.",
"Request": "Request",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const LabelSection: React.FC = () => {
<SelectorInput
onChange={(val) => setFieldValue('labels', SelectorInput.objectify(val))}
tags={labels}
placeholder={t('devconsole~appType=frontend')}
/>
</FormSection>
);
Expand Down
2 changes: 1 addition & 1 deletion frontend/public/components/utils/selector-input.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class SelectorInput extends React.Component {
autoFocus: this.props.autoFocus,
className: classNames('input', { 'invalid-tag': !isInputValid }),
onChange: this.handleInputChange.bind(this),
placeholder: _.isEmpty(tags) ? 'app=frontend' : '',
placeholder: _.isEmpty(tags) ? this.props.placeholder || 'app=frontend' : '',
spellCheck: 'false',
value: inputValue,
id: 'tags-input',
Expand Down

0 comments on commit 3c22e1b

Please sign in to comment.