Merge pull request #4926 from rohitkrai03/yaml-editor-fix

Bug 1820307: Hide yaml editor links when window width is less than 991px
openshift · Apr 7, 2020 · 441cb8a · 441cb8a
2 parents c77f777 + 3a470f0
commit 441cb8a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/frontend/packages/console-shared/src/components/editor/YAMLEditorToolbar.scss b/frontend/packages/console-shared/src/components/editor/YAMLEditorToolbar.scss
@@ -1,11 +1,13 @@
+@import '~bootstrap-sass/assets/stylesheets/bootstrap/variables';
+
 .ocs-yaml-editor-toolbar {
   &__links {
     display: flex;
     flex-shrink: 0;
     justify-content: flex-end;
     margin: 2px;
     z-index: 1;
-    @media(max-width: 767px) {
+    @media(max-width: $screen-sm-max) {
       display: none;
     }
   }

diff --git a/frontend/public/components/edit-yaml.jsx b/frontend/public/components/edit-yaml.jsx
@@ -58,7 +58,7 @@ export const EditYAML_ = connect(stateToProps)(
         stale: false,
         sampleObj: props.sampleObj,
         fileUpload: props.fileUpload,
-        showSidebar: props.create,
+        showSidebar: !!props.create,
       };
       this.monacoRef = React.createRef();
       // k8s uses strings for resource versions