Skip to content

Commit

Permalink
Merge pull request #8082 from makambalaji/odc-5475-update-setting-jso…
Browse files Browse the repository at this point in the history
…n-in-frontend

odc-5475-updated setting.json in frontend folder
  • Loading branch information
openshift-merge-robot committed Feb 13, 2021
2 parents e7956c8 + a961b24 commit 4a05bb2
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 6 deletions.
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ cypress-a11y-report.json
/frontend/**/dist
/frontend/@types/gql
/frontend/gui_test_screenshots
/frontend/packages/integration-tests-cypress/cypress-a11y-report.json
/frontend/packages/ceph-storage-plugin/integration-tests-cypress/cypress-a11y-report.json
/frontend/@types
/frontend/package-lock.json
/frontend/po-files
5 changes: 3 additions & 2 deletions frontend/.gherkin-lintrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"no-dupe-scenario-names": ["on", "in-feature"],
"no-dupe-feature-names": "on",
"no-partially-commented-tag-lines": "on",
"indentation" : ["on", {"Feature": 0, "Background": 4, "Scenario": 4, "Step": 8, "Examples": 8, "example": 12, "given": 8, "when": 8, "then": 8, "and": 8, "but": 8, "feature tag": 0, "scenario tag": 4}],
"indentation" : ["off", {"Feature": 0, "Background": 4, "Scenario": 4, "Step": 8, "Examples": 8, "example": 12, "given": 8, "when": 8, "then": 8, "and": 8, "but": 8, "feature tag": 0, "scenario tag": 4}],
"no-trailing-spaces": "on",
"new-line-at-eof": ["on", "yes"],
"no-multiple-empty-lines": "off",
Expand All @@ -22,5 +22,6 @@
"no-unused-variables": "on",
"no-background-only-scenario": "on",
"no-empty-background": "on",
"scenario-size": ["on", { "steps-length": {"Background": 5, "Scenario": 15}}]
"scenario-size": ["on", { "steps-length": {"Background": 5, "Scenario": 15}}],
"max-scenarios-per-file": ["on", {"maxScenarios": 10, "countOutlineExamples": true}]
}
6 changes: 4 additions & 2 deletions frontend/.vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,10 @@
},
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
}

},
"cucumberautocomplete.steps": ["./packages/*/integration-tests/support/step-definitions/*/*.ts"],
"cucumberautocomplete.strictGherkinCompletion": true,
"editor.quickSuggestions": true
// TODO support prettier + stylelint
// "prettier.stylelintIntegration": true,
// "css.validate": false,
Expand Down
5 changes: 5 additions & 0 deletions frontend/packages/gitops-plugin/integration-tests/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
reviewers:
- gajanan-more
- sanketpathak
approvers:
- makambalaji
5 changes: 5 additions & 0 deletions frontend/packages/helm-plugin/integration-tests/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
reviewers:
- gajanan-more
- sanketpathak
approvers:
- makambalaji
5 changes: 5 additions & 0 deletions frontend/packages/pipelines-plugin/integration-tests/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
reviewers:
- gajanan-more
- sanketpathak
approvers:
- makambalaji

0 comments on commit 4a05bb2

Please sign in to comment.