Fix buildConfig filter

openshift · Jun 19, 2023 · 50e42de · 50e42de
1 parent 2ad2c26
commit 50e42de
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/frontend/public/components/build-config.tsx b/frontend/public/components/build-config.tsx
@@ -366,10 +366,14 @@ export const BuildConfigsPage: React.FC<BuildConfigsPageProps> = (props) => {
       items: allStrategies,
     },
     {
-      filterGroupName: t('public~Build status'),
-      type: 'build-status',
+      filterGroupName: t('public~BuildRun status'),
+      type: 'build-run-status',
       reducer: buildStatus,
       items: statusFilters,
+      filter: (filterValue, build: BuildConfig): boolean => {
+        const status = build?.latestBuild?.status?.phase;
+        return !filterValue.selected?.length || (status && filterValue.selected.includes(status));
+      },
     },
   ];
 

diff --git a/frontend/public/locales/en/public.json b/frontend/public/locales/en/public.json
@@ -76,7 +76,7 @@
   "Source": "Source",
   "Custom": "Custom",
   "Build strategy": "Build strategy",
-  "Build status": "Build status",
+  "BuildRun status": "BuildRun status",
   "Pipeline build logs are available through Jenkins (linked below)": "Pipeline build logs are available through Jenkins (linked below)",
   "A link to the Jenkins pipeline build logs will appear below when the build starts": "A link to the Jenkins pipeline build logs will appear below when the build starts",
   "See Jenkins log": "See Jenkins log",