Change Jobs completions column data to sort on succeeded completions

bug https://bugzilla.redhat.com/show_bug.cgi?id=1902003
openshift · Jan 21, 2021 · 5a410f1 · 5a410f1
1 parent 6c8c292
commit 5a410f1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/frontend/public/components/factory/table.tsx b/frontend/public/components/factory/table.tsx
@@ -131,7 +131,7 @@ const sorts = {
   dataSize: (resource) => _.size(_.get(resource, 'data')) + _.size(_.get(resource, 'binaryData')),
   ingressValidHosts,
   serviceCatalogStatus,
-  jobCompletions: (job) => getJobTypeAndCompletions(job).completions,
+  jobCompletionsSucceeded: (job) => job?.status?.succeeded || 0,
   jobType: (job) => getJobTypeAndCompletions(job).type,
   nodeReadiness: (node: NodeKind) => {
     let readiness = _.get(node, 'status.conditions');

diff --git a/frontend/public/components/job.tsx b/frontend/public/components/job.tsx
@@ -217,7 +217,7 @@ const JobsList: React.FC = (props) => {
     },
     {
       title: t('public~Completions'),
-      sortFunc: 'jobCompletions',
+      sortFunc: 'jobCompletionsSucceeded',
       transforms: [sortable],
       props: { className: tableColumnClasses[3] },
     },