Merge pull request #13487 from lokanandaprabhu/feature/OCPBUGS-26415

OCPBUGS-26415: Application creation fail when manually entering input scaling value in local setup
openshift · Mar 12, 2024 · 63e97fa · 63e97fa
2 parents 395ac92 + 3473b1a
commit 63e97fa
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/frontend/packages/console-shared/src/components/formik-fields/NumberSpinnerField.tsx b/frontend/packages/console-shared/src/components/formik-fields/NumberSpinnerField.tsx
@@ -8,7 +8,16 @@ import { RedExclamationCircleIcon } from '../status';
 import { FieldProps } from './field-types';
 import { getFieldId } from './field-utils';
 
-const NumberSpinnerField: React.FC<FieldProps> = ({ label, helpText, required, ...props }) => {
+interface NumberSpinnerFieldProps extends FieldProps {
+  setOutputAsIntegerFlag?: boolean;
+}
+
+const NumberSpinnerField: React.FC<NumberSpinnerFieldProps> = ({
+  label,
+  helpText,
+  required,
+  ...props
+}) => {
   const [field, { touched, error }] = useField(props.name);
   const { setFieldValue, setFieldTouched } = useFormikContext<FormikValues>();
   const fieldId = getFieldId(props.name, 'number-spinner');
@@ -20,9 +29,14 @@ const NumberSpinnerField: React.FC<FieldProps> = ({ label, helpText, required, .
   const handleChange: React.ReactEventHandler<HTMLInputElement> = React.useCallback(
     (event) => {
       field.onChange(event);
-      setFieldValue(props.name, event.currentTarget.value);
+      setFieldValue(
+        props.name,
+        props?.setOutputAsIntegerFlag
+          ? _.toInteger(event.currentTarget.value)
+          : event.currentTarget.value,
+      );
     },
-    [field, props.name, setFieldValue],
+    [field, props.name, setFieldValue, props?.setOutputAsIntegerFlag],
   );
 
   return (

diff --git a/frontend/packages/dev-console/src/components/import/advanced/ScalingSection.tsx b/frontend/packages/dev-console/src/components/import/advanced/ScalingSection.tsx
@@ -15,6 +15,7 @@ const ScalingSection: React.FC<{ name: string }> = ({ name }) => {
         name={name}
         label={t('devconsole~Replicas')}
         helpText={t('devconsole~The number of instances of your Image.')}
+        setOutputAsIntegerFlag
       />
     </FormSection>
   );