Add name to coderef function.

Async component compares functions by name too.
openshift · Aug 10, 2021 · 85c8c03 · 85c8c03
1 parent 1104990
commit 85c8c03
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/frontend/packages/console-dynamic-plugin-sdk/src/coderefs/coderef-resolver.ts b/frontend/packages/console-dynamic-plugin-sdk/src/coderefs/coderef-resolver.ts
@@ -105,7 +105,9 @@ export const resolveEncodedCodeRefs = (
       const executableCodeRef: CodeRef = async () =>
         loadReferencedObject(ref, entryModule, pluginID, errorCallback);
 
-      e.properties[propName] = applyCodeRefSymbol(executableCodeRef);
+      const loader = applyCodeRefSymbol(executableCodeRef);
+      Object.defineProperty(loader, 'name', { value: ref.$codeRef });
+      e.properties[propName] = loader;
     });
 
     return e;

diff --git a/frontend/public/components/utils/async.tsx b/frontend/public/components/utils/async.tsx
@@ -8,7 +8,7 @@ import { LoadingBox } from './status-box';
  */
 const sameLoader = (a: () => Promise<React.ComponentType>) => (
   b: () => Promise<React.ComponentType>,
-) => (a || 'a').toString() === (b || 'b').toString();
+) => a?.name === b?.name && (a || 'a').toString() === (b || 'b').toString();
 
 enum AsyncComponentError {
   ComponentNotFound = 'COMPONENT_NOT_FOUND',