Merge pull request #5583 from yaacov/improve-vm-details-tabs-add-butt…

…ons-id Bug 1839927: Improve vm details tabs add buttons
openshift · May 27, 2020 · 91e682e · 91e682e
2 parents 88b7689 + 24201ea
commit 91e682e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/frontend/packages/kubevirt-plugin/integration-tests/views/kubevirtUIResource.view.ts b/frontend/packages/kubevirt-plugin/integration-tests/views/kubevirtUIResource.view.ts
@@ -2,8 +2,8 @@ import { $, browser, ExpectedConditions as until, element, by } from 'protractor
 import { resourceRows } from '@console/internal-integration-tests/views/crud.view';
 import { click } from '@console/shared/src/test-utils/utils';
 
-export const createNICButton = $('#create-nic-btn');
-export const createDiskButton = $('#create-disk-btn');
+export const createNICButton = $('#add-nic');
+export const createDiskButton = $('#add-disk');
 
 export const modalSubmitButton = $('.modal-content .pf-m-primary');
 export const cancelButton = element(by.buttonText('Cancel'));

diff --git a/frontend/packages/kubevirt-plugin/src/components/vm-disks/vm-disks.tsx b/frontend/packages/kubevirt-plugin/src/components/vm-disks/vm-disks.tsx
@@ -164,6 +164,7 @@ export const VMDisks: React.FC<VMDisksProps> = ({ vmLikeEntity, vmTemplate }) =>
       createProps={{
         isDisabled: isLocked,
         onClick: createFn,
+        id: 'add-disk',
       }}
       rowFilters={[diskSourceFilter]}
       customData={{

diff --git a/frontend/packages/kubevirt-plugin/src/components/vm-nics/vm-nics.tsx b/frontend/packages/kubevirt-plugin/src/components/vm-nics/vm-nics.tsx
@@ -117,7 +117,7 @@ export const VMNics: React.FC<VMLikeEntityTabProps> = ({ obj: vmLikeEntity }) =>
           <div className="co-m-pane__filter-bar-group">
             <Button
               variant={ButtonVariant.primary}
-              id="create-nic-btn"
+              id="add-nic"
               onClick={() =>
                 withProgress(
                   nicModalEnhanced({