Skip to content

Commit

Permalink
add await to create Image Stream request in deploy-image
Browse files Browse the repository at this point in the history
  • Loading branch information
sahil143 committed Feb 25, 2020
1 parent 82e2e34 commit acd09a7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
1 change: 0 additions & 1 deletion frontend/integration-tests/tests/deploy-image.scenario.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ describe('Deploy Image', () => {

it('should render applications dropdown disabled', async () => {
// Navigate to the deploy-image page
await browser.get(`${appHost}/deploy-image/ns/${testName}?preselected-ns=${testName}`);

const dropdown = '[data-test-id=namespace-bar-dropdown] > *:nth-child(2) button:disabled';
// Wait for the Applications dropdown to appear
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -359,9 +359,12 @@ export const createOrUpdateDeployImageResources = async (
}
if (formData.resources !== Resources.KnativeService) {
registry === RegistryType.External &&
requests.push(
createOrUpdateImageStream(formData, dryRun, _.get(appResources, 'imageStream.data'), verb),
);
(await createOrUpdateImageStream(
formData,
dryRun,
_.get(appResources, 'imageStream.data'),
verb,
));
if (formData.resources === Resources.Kubernetes) {
requests.push(
createOrUpdateDeployment(
Expand Down

0 comments on commit acd09a7

Please sign in to comment.