Add missing PropTypes, fix invalid prop to fix build

openshift · Dec 3, 2020 · d9b7828 · d9b7828
1 parent cee29a2
commit d9b7828
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/frontend/packages/console-shared/src/components/dynamic-form/fields.tsx b/frontend/packages/console-shared/src/components/dynamic-form/fields.tsx
@@ -330,7 +330,7 @@ export const DropdownField: React.FC<FieldProps> = ({
   uiSchema = {},
 }) => {
   const { t } = useTranslation();
-  const { items, title } = getUiOptions(uiSchema);
+  const { items, title } = getUiOptions(uiSchema) as { items?: object; title?: string };
   return (
     <Dropdown
       id={idSchema.$id}

diff --git a/frontend/public/components/routes/create-route.tsx b/frontend/public/components/routes/create-route.tsx
@@ -664,7 +664,7 @@ export const AlternateServicesGroup: React.FC<AlternateServiceEntryGroupProps> =
           dropDownClassName="dropdown--full-width"
           id={`${index}-alt-service`}
           onChange={onServiceChange}
-          describedby={`${index}-alt-service-help`}
+          describedBy={`${index}-alt-service-help`}
         />
         <div className="help-block" id={`${index}-alt-service-help`}>
           <p>Alternate service to route to.</p>

diff --git a/frontend/public/components/utils/dropdown.jsx b/frontend/public/components/utils/dropdown.jsx
@@ -196,7 +196,6 @@ class DropDownRow extends React.PureComponent {
   }
 }
 
-/** @augments {React.Component<any>} */
 class Dropdown_ extends DropdownMixin {
   constructor(props) {
     super(props);
@@ -597,6 +596,15 @@ Dropdown.propTypes = {
   textFilter: PropTypes.string,
   title: PropTypes.node,
   disabled: PropTypes.bool,
+  id: PropTypes.string,
+  onChange: PropTypes.func,
+  selectedKey: PropTypes.string,
+  titlePrefix: PropTypes.string,
+  ariaLabel: PropTypes.string,
+  name: PropTypes.string,
+  autoSelect: PropTypes.bool,
+  describedBy: PropTypes.string,
+  required: PropTypes.bool,
 };
 
 class ActionsMenuDropdown_ extends DropdownMixin {