Merge pull request #9247 from rottencandy/fix/gitlab-host-url

Always use http protocol for gitlab host
openshift · Jun 15, 2021 · ec8dce1 · ec8dce1
2 parents 72fbfc8 + b043f30
commit ec8dce1
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/frontend/packages/git-service/src/services/gitlab-service.ts b/frontend/packages/git-service/src/services/gitlab-service.ts
@@ -58,11 +58,9 @@ export class GitlabService extends BaseService {
   };
 
   getRepoMetadata(): RepoMetadata {
-    const { name, owner, protocol, resource, full_name: fullName } = GitUrlParse(
-      this.gitsource.url,
-    );
+    const { name, owner, resource, full_name: fullName } = GitUrlParse(this.gitsource.url);
     const contextDir = removeLeadingSlash(this.gitsource.contextDir);
-    const host = `${protocol}://${resource}`;
+    const host = `https://${resource}`;
     return {
       repoName: name,
       owner,
@@ -96,7 +94,7 @@ export class GitlabService extends BaseService {
       await this.getRepo();
       return RepoStatus.Reachable;
     } catch (e) {
-      if (e.response.status === 429) {
+      if (e.response?.status === 429) {
         return RepoStatus.RateLimitExceeded;
       }
     }