oh-something-went-wrong-imgmanifastvul-page

openshift · Feb 13, 2024 · f401207 · f401207
1 parent 962ab7b
commit f401207
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 14 deletions.
diff --git a/frontend/packages/container-security/src/components/image-manifest-vuln.tsx b/frontend/packages/container-security/src/components/image-manifest-vuln.tsx
@@ -55,6 +55,7 @@ export const highestSeverityIndex = (obj: ImageManifestVuln) =>
 
 export const ImageManifestVulnDetails: React.FC<ImageManifestVulnDetailsProps> = (props) => {
   const { t } = useTranslation();
+  const queryURL = quayURLFor(props.obj);
   return (
     <>
       <div className="co-m-pane__body">
@@ -78,10 +79,11 @@ export const ImageManifestVulnDetails: React.FC<ImageManifestVulnDetailsProps> =
                 obj={props.obj}
                 path="obj.spec.manifest"
               >
-                <ExternalLink
-                  text={shortenHash(props.obj.spec.manifest)}
-                  href={quayURLFor(props.obj)}
-                />
+                {queryURL ? (
+                  <ExternalLink text={shortenHash(props.obj.spec.manifest)} href={queryURL} />
+                ) : (
+                  <span className="small text-muted">-</span>
+                )}
               </DetailsItem>
             </dl>
           </div>
@@ -157,6 +159,7 @@ export const ImageManifestVulnTableRow: React.FC<RowFunctionArgs<ImageManifestVu
   obj,
 }) => {
   const { name, namespace } = obj.metadata;
+  const queryURL = quayURLFor(obj);
   return (
     <>
       <TableData className={tableColumnClasses[0]}>
@@ -184,7 +187,11 @@ export const ImageManifestVulnTableRow: React.FC<RowFunctionArgs<ImageManifestVu
       <TableData className={tableColumnClasses[4]}>{obj.status?.fixableCount || 0}</TableData>
       <TableData className={tableColumnClasses[5]}>{totalCount(obj)}</TableData>
       <TableData className={tableColumnClasses[6]}>
-        <ExternalLink text={shortenHash(obj.spec.manifest)} href={quayURLFor(obj)} />
+        {queryURL ? (
+          <ExternalLink text={shortenHash(obj.spec.manifest)} href={queryURL} />
+        ) : (
+          <span className="small text-muted">-</span>
+        )}
       </TableData>
     </>
   );

diff --git a/frontend/packages/container-security/src/components/summary.tsx b/frontend/packages/container-security/src/components/summary.tsx
@@ -37,14 +37,15 @@ export const securityHealthHandler: ResourceHealthHandler<WatchImageVuln> = ({
   return { state: HealthState.OK, message: '0 vulnerable images' };
 };
 
-export const quayURLFor = (vuln: ImageManifestVuln) => {
-  const base = vuln.spec.image
-    .replace('@sha256', '')
-    .split('/')
-    .reduce((url, part, i) => [...url, part, ...(i === 0 ? ['repository'] : [])], [])
-    .join('/');
-  return `//${base}/manifest/${vuln.spec.manifest}?tab=vulnerabilities`;
-};
+export const quayURLFor = (vuln: ImageManifestVuln) =>
+  // The first part of the url is the base
+  vuln?.spec?.image
+    ? `//${vuln.spec.image
+        .replace('@sha256', '')
+        .split('/')
+        .reduce((url, part, i) => [...url, part, ...(i === 0 ? ['repository'] : [])], [])
+        .join('/')}/manifest/${vuln.spec?.manifest}?tab=vulnerabilities`
+    : '';
 
 export const SecurityBreakdownPopup: React.FC<SecurityBreakdownPopupProps> = ({
   imageManifestVuln,
@@ -184,7 +185,11 @@ export const SecurityBreakdownPopup: React.FC<SecurityBreakdownPopupProps> = ({
                     </Link>
                   </span>
                   <div className="text-secondary">
-                    <ExternalLink href={quayURLFor(v)} text={getVulnerabilityCountText(v)} />
+                    {quayURLFor(v) ? (
+                      <ExternalLink href={quayURLFor(v)} text={getVulnerabilityCountText(v)} />
+                    ) : (
+                      <span className="small text-muted">-</span>
+                    )}
                   </div>
                 </div>
               ))}