Merge pull request #8681 from openshift-cherrypick-robot/cherry-pick-…

…8670-to-release-4.7 [release-4.7] Bug 1950214: Fix start pipeline action access review
openshift · Apr 29, 2021 · f66f4f8 · f66f4f8
2 parents 66a6ffd + 69e114a
commit f66f4f8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/frontend/packages/pipelines-plugin/src/utils/__tests__/pipeline-actions.spec.ts b/frontend/packages/pipelines-plugin/src/utils/__tests__/pipeline-actions.spec.ts
@@ -39,6 +39,13 @@ describe('PipelineAction testing startPipeline create correct labels and callbac
   });
 });
 
+describe('PipelineAction testing startPipeline to check the pipelinerun access review', () => {
+  it('expect access review check on pipelinerun resource', () => {
+    const pipeline = startPipeline(PipelineModel, samplePipeline);
+    expect(pipeline.accessReview.resource).toBe(PipelineRunModel.plural);
+  });
+});
+
 describe('PipelineAction testing stopPipelineRun create correct labels and callbacks', () => {
   it('expect label to be "Stop" with hidden flag as false when latest Run is running', () => {
     const stopAction = stopPipelineRun(PipelineRunModel, {

diff --git a/frontend/packages/pipelines-plugin/src/utils/pipeline-actions.tsx b/frontend/packages/pipelines-plugin/src/utils/pipeline-actions.tsx
@@ -101,9 +101,8 @@ export const startPipeline: KebabAction = (
     }
   },
   accessReview: {
-    group: kind.apiGroup,
-    resource: kind.plural,
-    name: pipeline.metadata.name,
+    group: PipelineRunModel.apiGroup,
+    resource: PipelineRunModel.plural,
     namespace: pipeline.metadata.namespace,
     verb: 'create',
   },