Skip to content

Commit

Permalink
Merge pull request #5487 from yaacov/add-divider-before-field-selecto…
Browse files Browse the repository at this point in the history
…r-in-affinity-form

Bug 1828993: Add divider line befor field selectors
  • Loading branch information
openshift-merge-robot committed May 19, 2020
2 parents 3b2eefa + 9fe483d commit f810e11
Showing 1 changed file with 19 additions and 1 deletion.
Expand Up @@ -211,7 +211,7 @@ export const AffinityEdit: React.FC<AffinityEditProps> = ({
</Text>
<Text className="scheduling-modals__desc" component={TextVariants.small}>
{
'Note that for Node field expressions, entering a full path is required in the Key field (e.g. `metadata.name: value`)'
'Label selectors let you select Nodes based on the value of one or more labels.'
}
</Text>
<Text className="scheduling-modals__desc" component={TextVariants.small}>
Expand All @@ -236,12 +236,30 @@ export const AffinityEdit: React.FC<AffinityEditProps> = ({
</FormRow>
{isNodeAffinity && (
<>
<Divider component="div" />
<FormRow
title="Node Fields"
fieldId={'fields'}
validationType={isFieldsInvalid && ValidationErrorType.Error}
validationMessage={isFieldsInvalid && 'Missing fields in node fields'}
>
<div className="scheduling-modals__desc-container">
<>
<Text className="scheduling-modals__desc" component={TextVariants.small}>
{
'Field selectors let you select Nodes based on the value of one or more resource fields.'
}
</Text>
<Text className="scheduling-modals__desc" component={TextVariants.small}>
{
'Note that for Node field expressions, entering a full path is required in the Key field (e.g. `metadata.name: value`).'
}
</Text>
<Text className="scheduling-modals__desc" component={TextVariants.small}>
{'Some fields may not be supported.'}
</Text>
</>
</div>
<AffinityExpressionList
expressions={affinityFields}
addRowText="Add Field"
Expand Down

0 comments on commit f810e11

Please sign in to comment.