Skip to content

Commit

Permalink
Remove orphaned patternfly-react 3 styles and patternfly-react 3 depe…
Browse files Browse the repository at this point in the history
…ndency
  • Loading branch information
rhamilto committed Jul 9, 2021
1 parent cb618e6 commit f9e6b0d
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 359 deletions.
1 change: 0 additions & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@
"null-loader": "^3.0.0",
"openshift-logos-icon": "1.7.1",
"patternfly": "^3.59.5",
"patternfly-react": "2.39.16",
"pluralize": "^8.0.0",
"point-in-svg-path": "1.0.1",
"popper.js": "^1.15.0",
Expand Down
14 changes: 1 addition & 13 deletions frontend/packages/kubevirt-plugin/src/style.scss
Original file line number Diff line number Diff line change
@@ -1,20 +1,8 @@
// All PF3 css imports here are needed for react-console

// Bootstrap Core variables and mixins
@import "~bootstrap-sass/assets/stylesheets/bootstrap/variables";
@import "~bootstrap-sass/assets/stylesheets/bootstrap/mixins";

// Patternfly Core variables and mixins
@import "~patternfly/dist/sass/patternfly/variables";
@import "~patternfly/dist/sass/patternfly/bootstrap-mixin-overrides";
@import "~patternfly/dist/sass/patternfly/mixins";
@import "~patternfly-react/dist/sass/patternfly-react";

// Console StyleSheets
@import "~xterm/css/xterm.css";

// Note(yaacov): Workaround bootstrap issue, checkbox and radio buttons are not alligned with input label
// hack should be removed once bootstrap is fixed
input[type="radio"], input[type="checkbox"] {
margin-top: 1px !important;
}
}
5 changes: 0 additions & 5 deletions frontend/packages/operator-lifecycle-manager/src/style.scss
Original file line number Diff line number Diff line change
@@ -1,13 +1,8 @@
// Bootstrap Core variables and mixins
@import '~bootstrap-sass/assets/stylesheets/bootstrap/variables';
@import '~bootstrap-sass/assets/stylesheets/bootstrap/mixins';

// Patternfly Core variables and mixins
@import '~patternfly/dist/sass/patternfly/variables';
@import '~patternfly/dist/sass/patternfly/bootstrap-mixin-overrides';
@import '~patternfly/dist/sass/patternfly/mixins';
@import '~patternfly/dist/sass/patternfly/icons';
@import '~patternfly-react/dist/sass/patternfly-react';

// OpenShift variables
@import '../../../public/style/vars';
Expand Down
23 changes: 0 additions & 23 deletions frontend/public/style/_overrides.scss
Original file line number Diff line number Diff line change
Expand Up @@ -49,29 +49,6 @@ kbd {
box-shadow: inset 0 0 0 1px rgba(0, 0, 0, 0.25);
}

.modal.right-side-modal-pf {
top: 76px; // since PatternFly 4's masthead is taller than PatternFly 3's

.modal-dialog {
height: 100%; // Entend panel to bottom
margin-top: 0; // parent is positioned: fixed so margin isn't needed for positioning

.modal-content {
height: 100%; // Use % instead of vh so that scroll-shadows can be used
max-height: none;
}
}

&.fade {
.modal-dialog {
transition-duration: 200ms;
}
&:not(.in) .modal-dialog {
transform: translate3d(15px, 0, 0);
}
}
}

.modal-footer .alert {
text-align: left;
}
Expand Down

0 comments on commit f9e6b0d

Please sign in to comment.