Merge pull request #4098 from kyoto/monitoring-dashboards-dropdown-ti…

…tles Bug 1796441: Monitoring Dashboards: Capitalize dropdown titles for variables
openshift · Jan 30, 2020 · fd3245a · fd3245a
2 parents 41331e2 + 5904166
commit fd3245a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/frontend/public/components/monitoring/_monitoring.scss b/frontend/public/components/monitoring/_monitoring.scss
@@ -6,6 +6,10 @@
   width: 140px;
 }
 
+.monitoring-dashboards__dropdown-title {
+  text-transform: capitalize;
+}
+
 .monitoring-dashboards__dropdown-wrap {
   margin-right: 20px;
 }

diff --git a/frontend/public/components/monitoring/dashboards/index.tsx b/frontend/public/components/monitoring/dashboards/index.tsx
@@ -43,7 +43,7 @@ const VariableDropdown: React.FC<VariableDropdownProps> = ({
   title,
 }) => (
   <div className="form-group monitoring-dashboards__dropdown-wrap">
-    {title && <label>{title}</label>}
+    <label className="monitoring-dashboards__dropdown-title">{title}</label>
     <Dropdown
       buttonClassName={buttonClassName}
       items={items}
@@ -391,7 +391,7 @@ type VariableDropdownProps = {
   items: { [key: string]: string };
   onChange: (v: string) => void;
   selectedKey: string;
-  title?: string;
+  title: string;
 };
 
 type BoardProps = {